Skip to content

Added parameter to remove scroll from Panel content #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexiv0re merged 1 commit into from
Oct 22, 2023
Merged

Added parameter to remove scroll from Panel content #3865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/panel/src/components/Panel.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
export let embedded = false
export let contentClasses: string | undefined = undefined
export let content: HTMLElement | undefined | null = undefined
export let withoutContentScroll: boolean = false

let lastHref: string
let timer: any
Expand Down Expand Up @@ -206,6 +207,24 @@
{/key}
{/if}
</div>
{:else if withoutContentScroll}
<div class={contentClasses ?? 'popupPanel-body__main-content py-8 clear-mins'} class:max={useMaxWidth}>

@aonnikov aonnikov Oct 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sol-0 you should bind content variable here

@sol-0 sol-0 Oct 23, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed your comment in the new PR - #3868
Thanks!

<slot />
{#if !withoutActivity}
{#key object._id}
<Component
is={activity.component.Activity}
props={{
object,
showCommenInput: !withoutInput,
shouldScroll: embedded,
focusIndex: 1000,
boundary: content
}}
/>
{/key}
{/if}
</div>
{:else}
<Scroller
bind:divScroll={content}
Expand Down