Pin maximum TF version#18818
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Aug 30, 2022
Member
There was a problem hiding this comment.
Looks good to me, let's not forget to unpin! (Great minds think alike, @ydshieh!)
Contributor
Author
|
@ydshieh the CI fail seems unrelated 🤔 do you know potential causes? |
Collaborator
|
Unfortunately no. Let me find some time to take a look, but I think you are good to merge :-) |
Member
|
Yes I think that's an unrelated error linked to a new cache being made as the Let's merge this PR! Thanks for your contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We now also depend on
tensorflow-text, whose minor versions are typically released a few days after newtensorflowreleases. From tests against thetensorflowrelease candidate,tensorflow-text-based functions fail when these two libraries do not have the same version.This PR pins the maximum TF version so that our CI doesn't break with the upcoming
tensorflowrelease. When the correspondingtensorflow-textlibrary gets released we should be able to unpin it again.