fix: allow num_labels property to return None when id2label is unset - #47069
Merged
zucchini-nlp merged 5 commits intoJul 16, 2026
Merged
Conversation
The property was annotated as returning int but returned None when id2label is missing, which contradicts the type and can break type checkers and careful callers. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Member
|
Hopefully fixed now on main |
Contributor
|
Thank you for your contribution 🤗! CI Security Gate — automatic approval blockedThis PR was not automatically approved for CI because the security gate failed. Possible reasons:
See the workflow run for the exact violations. A maintainer can review and manually approve CI if a finding is a false positive. |
zucchini-nlp
enabled auto-merge
July 16, 2026 13:01
Contributor
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Merged
via the queue into
huggingface:main
with commit Jul 16, 2026
d9f38e8
105 of 106 checks passed
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
…uggingface#47069) The property was annotated as returning int but returned None when id2label is missing, which contradicts the type and can break type checkers and careful callers. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> Co-authored-by: Raushan Turganbay <raushan@huggingface.co>
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
…uggingface#47069) The property was annotated as returning int but returned None when id2label is missing, which contradicts the type and can break type checkers and careful callers. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> Co-authored-by: Raushan Turganbay <raushan@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PretrainedConfig.num_labelswas annotated as-> intbut returnedNonewhenid2labelis not set.Change
Use
int | Noneand document the optional return value.Testing
Type annotation aligns with runtime behavior; no logic change.