TP dtensor#47194
Draft
3outeille wants to merge 11 commits into
Draft
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2_moe |
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distributed/tensor_parallel.py:model.train()uses DTensor redistribute;model.eval()uses plainall-reduce/all-gatherCohere2Moeis able to easily switch between training (dtensor) & inference (plainall-reduce). Other models (Llama, Mistral, Mixtral, Qwen3) stay on the legacy TP backendapply_tensor_parallel()dispatches to the new DTensor backend or the legacy integrations/tensor_parallel path ifenable_expert_parallel=Falseandstyle string in base_model_tp_plan use the new ALL_PARALLEL_STYLES registryshard-on-readloading;gather_tp_state_dict()for TP checkpoint savetp_sizecomes from thedevice_mesh, not fromdistributed_configfield