Deprecate CB config in gen configuration - #47291
Merged
Merged
Conversation
6 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Comment on lines
+467
to
469
| # Depreacted in 5.13 | ||
| self.continuous_batching_config = kwargs.pop("continuous_batching_config", None) | ||
|
|
Member
There was a problem hiding this comment.
we can raise a deprec warning here if continuous_batching_config is not None , hopefully there are no configs saved with CB config
zucchini-nlp
approved these changes
Jul 16, 2026
Contributor
CI recapDashboard: View test results in Grafana |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
* Depreacte CB config in gen config * Add depr msg
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
* Depreacte CB config in gen config * Add depr msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates passing a
ContinuousBatchingConfigthrough theGenerationConfigwhich is a different object: the generation config is model-centered while the CB config is hardware-centered. Closes #47039 .