Add FSDP CI and end-to-end FSDP tests + save fsdp - #47357
Merged
Conversation
…n 1/3). Introduce distributed/utils.py and DistributedMixin, defer DistributedConfig validation to load time, and refactor PreTrainedModel plan properties without changing the from_pretrained distributed_config API yet.
…SDP orchestration 2/3). Route distributed loading and saving through DistributedMixin, migrate TP tests and docs off tp_plan="auto", and add FSDP gather/DCP save paths.
Add FSDPTesterMixin, cohere2_moe base_fsdp_plan, dedicated fsdp_ci job, and pytest markers for distributed FSDP load/save/generation coverage.
Route distributed load/save orchestration through DistributedMixin so TP and FSDP paths share the same entry points.
3outeille
changed the title
This was referenced Jul 16, 2026
…gingface/transformers into split/a-pr-4-2-fsdp-tests-ci
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
3outeille
marked this pull request as ready for review
July 21, 2026 05:31
3outeille
changed the title
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
wondering if any of the func in the test fsdp mixin are re-usable at all?
| continue | ||
| self.skipTest(f"Cannot instantiate model with any Auto class for config {type(config).__name__}") | ||
|
|
||
| def _get_tiny_config(self): |
Collaborator
There was a problem hiding this comment.
are you patching to make divisable?
Member
Author
There was a problem hiding this comment.
no I am just patching to make it a smaller model overall
| """The model exposes a non-empty `_fsdp_plan` derived from config + class-level overrides.""" | ||
| if not self._has_fsdp_plan(): | ||
| self.skipTest("Model does not have an FSDP plan (base_model_fsdp_plan)") | ||
|
|
Collaborator
There was a problem hiding this comment.
create model on meta is used only once, not sure we need a func
ArthurZucker
approved these changes
Jul 23, 2026
…gingface/transformers into split/a-pr-4-2-fsdp-tests-ci
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2_moe |
Member
Author
|
run-slow: cohere2_moe |
Contributor
|
This comment contains models: ["models/cohere2_moe"] |
Contributor
CI recapDashboard: View test results in Grafana |
Contributor
CI ResultsCommit Info
The test failure analysis could not be completed. Please check the workflow run for details. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
* Add distributed runtime utils and DistributedMixin (FSDP orchestration 1/3). Introduce distributed/utils.py and DistributedMixin, defer DistributedConfig validation to load time, and refactor PreTrainedModel plan properties without changing the from_pretrained distributed_config API yet. * Wire DistributedConfig through from_pretrained and save_pretrained (FSDP orchestration 2/3). Route distributed loading and saving through DistributedMixin, migrate TP tests and docs off tp_plan="auto", and add FSDP gather/DCP save paths. * Add FSDP CI and end-to-end FSDP tests (FSDP orchestration 3/3). Add FSDPTesterMixin, cohere2_moe base_fsdp_plan, dedicated fsdp_ci job, and pytest markers for distributed FSDP load/save/generation coverage. * addd ep_plan * restore validate module * Wire DistributedConfig through from_pretrained and save_pretrained. Route distributed load/save orchestration through DistributedMixin so TP and FSDP paths share the same entry points. * revert * inline distribute_model * revert * remove saving/loading * leaner mixin * downgrade torch version guarding * remove * linting * revert * revert * post_init() parallel plan move to mixin * revert tp mixin * add save/load * only FSDP save/load for now * revert * refactor * inline
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
* Add distributed runtime utils and DistributedMixin (FSDP orchestration 1/3). Introduce distributed/utils.py and DistributedMixin, defer DistributedConfig validation to load time, and refactor PreTrainedModel plan properties without changing the from_pretrained distributed_config API yet. * Wire DistributedConfig through from_pretrained and save_pretrained (FSDP orchestration 2/3). Route distributed loading and saving through DistributedMixin, migrate TP tests and docs off tp_plan="auto", and add FSDP gather/DCP save paths. * Add FSDP CI and end-to-end FSDP tests (FSDP orchestration 3/3). Add FSDPTesterMixin, cohere2_moe base_fsdp_plan, dedicated fsdp_ci job, and pytest markers for distributed FSDP load/save/generation coverage. * addd ep_plan * restore validate module * Wire DistributedConfig through from_pretrained and save_pretrained. Route distributed load/save orchestration through DistributedMixin so TP and FSDP paths share the same entry points. * revert * inline distribute_model * revert * remove saving/loading * leaner mixin * downgrade torch version guarding * remove * linting * revert * revert * post_init() parallel plan move to mixin * revert tp mixin * add save/load * only FSDP save/load for now * revert * refactor * inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of FSDP orchestration stack (2/2). Replaces #46990. #47352 (1/2) → this PR (2/2)
FSDPTesterMixinandtests/test_fsdp_mixin.py(load/save/generation)base_model_fsdp_planto cohere2_moe (only model in this stack)fsdp_ciCircleCI job and pytest markers