Fix TimesFM 2.5 window_size AttributeError - #47363
Merged
Merged
Conversation
vasqu
approved these changes
Jul 16, 2026
vasqu
left a comment
Collaborator
There was a problem hiding this comment.
Can we add a fast test but modular got us good :D
4 tasks
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: timesfm2_5 |
Contributor
|
Thank you for your contribution 🤗! CI Security Gate — automatic approval blockedThis PR was not automatically approved for CI because the security gate failed. Possible reasons:
See the workflow run for the exact violations. A maintainer can review and manually approve CI if a finding is a false positive. |
vasqu
enabled auto-merge
July 16, 2026 13:21
Contributor
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
* fix timesfm2.5 window_size crash from wrong method name * add fast test for window_size
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
* fix timesfm2.5 window_size crash from wrong method name * add fast test for window_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
window_sizetoTimesFm2_5ModelForPredictioncrashed becauseforwardcalledself._timesfm_moving_average, but the modular converter renames the static method to_timesfm2_5_moving_average. Fixed the call site to match.Fixes #46821
Repro from the issue now runs fine: