Fix Daily CI reporting issues - #47364
Conversation
|
Triggered a new daily https://github.com/huggingface/transformers/actions/runs/29483227997 |
vasqu
left a comment
There was a problem hiding this comment.
Thanks, do you know why this happened all of a sudden? It only started failing a few days ago it seems
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
the July 13 issues are yet another issue I am looking at |
|
Checked run 29502875190: https://github.com/huggingface/transformers/actions/runs/29502875190 Result: failed, but the reporting fix path worked. Key signal: All 4 Model CI / Collated Reports jobs succeeded Those are: 87641539498 single-gpu slice 0 So #47364’s machine-type/matrix fix is doing what we wanted here: matrix jobs materialized, The run is red because model jobs failed: llama single + multi Examples:
No summary_short.txt / created_at / empty machine_type failure in the collated report jobs on this |
|
run-slow: whisper, wav2vec2, llama |
|
This comment contains models: ["models/llama", "models/wav2vec2", "models/whisper"] |
|
new run with the 3 fixes https://github.com/huggingface/transformers/actions/runs/29512139671 |
CI recapDashboard: View test results in Grafana |
* Fix model CI collated report machine type * Keep Nvidia model CI matrix below job limit * Handle missing summaries in collated reports
* Fix model CI collated report machine type * Keep Nvidia model CI matrix below job limit * Handle missing summaries in collated reports
What this PR does
Fix 1
The scheduled model CI collated report can fail before uploading reports with:
.github/workflows/model_jobs.ymlwas passingmachine_typeto the reusable collated report workflow fromneeds.run_models_gpu.outputs.machine_type.That job is matrixed, so relying on a matrix job output here can produce an empty value for the downstream reusable workflow.
This moves the normalized report machine type into a small non-matrix
report_metadatajob and passesneeds.report_metadata.outputs.machine_typetocollated-reports.yml. The per-matrix test job still setsmachine_typeinGITHUB_ENVfor artifact names exactly as before.Fix 2
The generated folder matrix crossed GitHub’s 256-job limit:
Added a slice
Fix 3
Some model CI jobs can upload a partial report artifact without summary_short.txt when pytest does
not reach its terminal summary hook. The collated report job then fails with:
FileNotFoundError: [Errno 2] No such file or directory:
'/summary_short.txt'
This makes utils/collated_reports.py tolerate missing summary_short.txt files. Instead of crashing
the entire collated report job, it records that artifact as an error entry and continues processing
the remaining reports.
This preserves the useful collated report output while still surfacing the malformed/incomplete
artifact as a failure signal.