Make tokenization_mistral_common importable without mistral_common installed - #47397
Merged
itazap merged 1 commit intoJul 24, 2026
Conversation
joa-stdn
reviewed
Jul 20, 2026
juliendenize
force-pushed
the
fix-mistral-common-import-without-dependency
branch
from
July 20, 2026 12:16
bb2eb64 to
cf3c4d1
Compare
Contributor
CI recapDashboard: View test results in Grafana |
joa-stdn
approved these changes
Jul 20, 2026
Member
|
looks ready for review so gentle ping @ArthurZucker @itazap |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tokenization_mistral_common.pyreferencedmistral_common-only symbols at import time, so the module raisedNameErrorwhenmistral_commonwas not installed. Those symbols are only imported inside theif is_mistral_common_available():block, so they are undefined at module scope otherwise. This is not reachable through normalAutoTokenizerusage today since the module is only imported behind anis_mistral_common_available()guard, but this makes the module safe to import unconditionally.The import-time references were the module-level
_MAP_SPECIAL_TOKENSdict, themodedefault arguments (ValidationMode.test, now the equivalent string"test"), and a few signature annotations referencingValidationMode/ReasoningEffort(now quoted since the module has nofrom __future__ import annotations). Added a test that executes the module body withmistral_commonboth available and unavailable to ensure the import never raises.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request checks?
to it if that's the case.
Who can review?
@ArthurZucker @itazap