Fix Gemma4 audio feature dtype mismatch in masked_scatter - #47482
Merged
Rocketknight1 merged 1 commit intoJul 23, 2026
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma4 |
Contributor
CI recapDashboard: View test results in Grafana |
Rocketknight1
enabled auto-merge
July 23, 2026 11:28
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
…e#47482) Co-authored-by: danielhanchen <unslothai@gmail.com>
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
…e#47482) Co-authored-by: danielhanchen <unslothai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Aligns the dtype of Gemma 4 audio features to the text-embedding dtype before
masked_scatter, so the audio merge behaves like the image and video merges.In
Gemma4Model.forward, the image and video branches cast their features toinputs_embeds.dtypebefore scattering them into the text embeddings:but the audio branch only moved the features to the correct device, never the dtype:
When
inputs_embedsand the audio encoder output end up in different dtypes (for example a float32 residual stream with a float16 audio tower, which happens under mixed-precision setups), this raises:The fix casts
audio_featurestoinputs_embeds.dtypein the same call, matching the image and video paths. Text-only, image, and video inference are unaffected since they already cast. The change is made inmodular_gemma4.pyand mirrored in the generatedmodeling_gemma4.py.Before submitting
Who can review?
@ArthurZucker @Cyrilvallez