Fix mamba2 family decode and simplify all reshape ops - #47569
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bamba, falcon_h1, granitemoehybrid, mamba2, nemotron_h, zamba2 |
Contributor
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
approved these changes
Jul 27, 2026
albertvillanova
left a comment
albertvillanova
left a comment
Member
There was a problem hiding this comment.
I tested this PR branch with TRL CI:
Before: https://github.com/huggingface/trl/actions/runs/30251482183/job/89930273248
FAILED tests/test_grpo_trainer.py::TestGRPOTrainer::test_train[trl-internal-testing/tiny-NemotronHForCausalLM-nano] - RuntimeError: expand(CUDABFloat16Type{[3, 1, 1, 8]}, size=[-1, -1, 4]): the number of sizes provided (3) must be greater or equal to the number of dimensions in the tensor (4)
FAILED tests/test_rloo_trainer.py::TestRLOOTrainer::test_train[trl-internal-testing/tiny-NemotronHForCausalLM-nano] - RuntimeError: expand(CUDABFloat16Type{[3, 1, 1, 8]}, size=[-1, -1, 4]): the number of sizes provided (3) must be greater or equal to the number of dimensions in the tensor (4)
= 2 failed
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. This supersedes #47533 with more simplifications instead of simply
squeezeing. Those models are all over the place in terms of reshape/view ops, so always a good idea to remove a few no-ops and shenanigans