[Fix] Swapped height and width in KimiK25 - #47786
Conversation
|
run-slow: kimi_k25 |
|
This comment contains models: ["models/kimi_k25"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks, let's just revert the cross-file import :)
| # Same resize as in image processing | ||
| def navit_resize( | ||
| width: int, | ||
| height: int, |
There was a problem hiding this comment.
this needs to be defined, as requested by core maintainers :)
recently we updated qwen-format processors to swap import with explicit redefinition, see #47573 (comment)
There was a problem hiding this comment.
Ok no problem! Just for my understanding sorry: why do we not like cross imports?
There was a problem hiding this comment.
bit of backstory - we had import issues in the past when importing between PIL-Torch backends, then Arthur decided to explicitly define these fn. Later on we also noticed modular doesn't work well with it, so now we also redefine them in video processors
and i guess it goes against "our philosophy of one file"?
There was a problem hiding this comment.
(tbh i also don't like redefining it 😆 )
There was a problem hiding this comment.
Ok thanks for the info!
There was a problem hiding this comment.
Mostly modular tbh, otherwise if we only implement the img or vid processor then we inherit the cross import and some magic later we try to import from non existing files
|
[For maintainers] Suggested jobs to run (before merge) run-slow: kimi_k25 |
CI recapDashboard: View test results in Grafana |
4 participants
This PR fixes an height / width inversion that was impacting Kimi K2.5 :
navit_resizewas called with theheightandwidtharguments swapped. This is fixed in this PR and a regression test was added.Also, the
navit_resizefunction was duplicated across two files (image and video processing) so now video only import from imagr rather than re-writing the fn.