Skip to content

Hotfix axk2 indexer norm - #47810

Merged
vasqu merged 4 commits into
huggingface:mainfrom
kmswin1:hotfix-axk2-indexer-norm
Aug 6, 2026
Merged

Hotfix axk2 indexer norm#47810
vasqu merged 4 commits into
huggingface:mainfrom
kmswin1:hotfix-axk2-indexer-norm

Conversation

@kmswin1

@kmswin1 kmswin1 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

CI

There is currently a mismatch between the HF and vLLM implementations of the AXK2 indexer input.
HF passes the pre-normalization q_compressed, directly after q_a_proj, to the indexer.
vLLM passes the post-normalization q_c, after q_a_layernorm, to the indexer.
This difference may change the indexer scores and top-k selections. For consistency, we are considering updating the HF implementation to match the current vLLM serving behavior by passing the post-normalization query to the indexer.
We are planning to submit the following change as a PR. Would it be possible to handle this as a hotfix and merge it quickly?
topk_indices = self.indexer(
hidden_states,

  • q_compressed,
  • q_resid, # post-normalization query
    position_embeddings,
    indexer_mask,
    position_ids,
    past_key_values=past_key_values,
    )
    This change only affects the indexer input. The main query and attention output-gate paths remain unchanged.!

@Rocketknight1

Copy link
Copy Markdown
Member

cc @vasqu since you added the original model!

@vasqu

vasqu commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Just did a small change to inherit completely from the indexer, merging now

@vasqu

vasqu commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Ah no let me update the expectations of the integration tests

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: axk2

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 31081375519:2
Result: success | Jobs: 8 | Tests: 377 | Failures: 0 | Duration: 2m 20s

@vasqu
vasqu merged commit f9531b0 into huggingface:main Aug 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants