Hotfix axk2 indexer norm - #47810
Merged
Merged
Conversation
Member
|
cc @vasqu since you added the original model! |
Collaborator
|
Just did a small change to inherit completely from the indexer, merging now |
Collaborator
|
Ah no let me update the expectations of the integration tests |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: axk2 |
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a mismatch between the HF and vLLM implementations of the AXK2 indexer input.
HF passes the pre-normalization q_compressed, directly after q_a_proj, to the indexer.
vLLM passes the post-normalization q_c, after q_a_layernorm, to the indexer.
This difference may change the indexer scores and top-k selections. For consistency, we are considering updating the HF implementation to match the current vLLM serving behavior by passing the post-normalization query to the indexer.
We are planning to submit the following change as a PR. Would it be possible to handle this as a hotfix and merge it quickly?
topk_indices = self.indexer(
hidden_states,
position_embeddings,
indexer_mask,
position_ids,
past_key_values=past_key_values,
)
This change only affects the indexer input. The main query and attention output-gate paths remain unchanged.!