Fix Verifier Key deserialization. #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnevadoc
force-pushed
the
fix-vk-serde
branch
from
67b56da to
f512267
Compare
davidnevadoc
force-pushed
the
fix-vk-serde
branch
from
f512267 to
aba82cb
Compare
davidnevadoc
changed the title
|
Closing in favour of https://github.com/input-output-hk/midnight-circuits/pull/179 |
iquerejeta
added a commit
that referenced
this pull request
May 8, 2024
…codecov/codecov-action-3.1.4 chore(deps): bump codecov/codecov-action from 3.1.0 to 3.1.4
dkaidalov
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Compare polynomials and polynomial commitments by reference. Issue #1 Not permit duplicate queries Issue #3 * Add Length of PIs to the transcript Issue #2 * Check trailing bytes Issue #6 * Panic if two points are equals in lagrange_interpolate. Issue #10 * Hash the byte representation of the VK in the transcript Issue #5 We do not add the architecture, as the verifier is already parametrised by that. * Consistency in polynomial multiplication Issue #7 We mutate the polynomial (with all zeroes) to be consistent with the behaviour. * Make commitment homomorphic, and don't send evals of pieces - Issue#0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The desiarlization of a VK involves recovering the circuit log size parameter
k. This value is read directly as au32without any checks. Its maximum allowed value is then~2^( 2^32), which can become an issue since it is used later in the desiarliazation to process the selector by initializing vectors of size2^k:https://github.com/input-output-hk/halo2/blob/b61d14bc15fd8692415f3dbbaa737a088ea57400/halo2_proofs/src/plonk.rs#L125C36-L125C36
There is a theoretic limitation of this value by the 2-adicity of the scalar field of the curves we use. All of the curves have a 2-adicity
<=32.Changes
Add a check that ensures
k <=32.