Reduce size of proving keys and verifying keys #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
2 times, most recently
from
c776b25 to
3169faa
Compare
iquerejeta
approved these changes
Apr 24, 2024
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
from
3169faa to
4796ecf
Compare
Co-authored-by: Iñigo Querejeta Azurmendi <31273774+iquerejeta@users.noreply.github.com>
miguel-ambrona
force-pushed
the
ambrona@smaller-vk
branch
from
238301d to
392b260
Compare
miguel-ambrona
changed the title
iquerejeta
approved these changes
Apr 26, 2024
iquerejeta
left a comment
iquerejeta
left a comment
There was a problem hiding this comment.
LGTM - is there an issue or a fix for this in the PSE fork? If yes, could we link it in this PR please?
Author
No, because I think this is more an internal Midnight need. |
iquerejeta
added a commit
that referenced
this pull request
May 8, 2024
* plonk/keygen: add function to compute l polys * plonk/permutation/keygen: add function to compute polys and cosets * plonk: improve size of serialized prover keys Co-authored-by: Iñigo Querejeta Azurmendi <31273774+iquerejeta@users.noreply.github.com> * plonk/keygen: disable complex selectors --------- Co-authored-by: Iñigo Querejeta Azurmendi <31273774+iquerejeta@users.noreply.github.com>
dkaidalov
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Compare polynomials and polynomial commitments by reference. Issue #1 Not permit duplicate queries Issue #3 * Add Length of PIs to the transcript Issue #2 * Check trailing bytes Issue #6 * Panic if two points are equals in lagrange_interpolate. Issue #10 * Hash the byte representation of the VK in the transcript Issue #5 We do not add the architecture, as the verifier is already parametrised by that. * Consistency in polynomial multiplication Issue #7 We mutate the polynomial (with all zeroes) to be consistent with the behaviour. * Make commitment homomorphic, and don't send evals of pieces - Issue#0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For proving keys, on "write" we skip some information which we can easily recompute on "read".
For verifying keys, we disable the complex selector flag globally.