Fix number of rows #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
force-pushed
the
iquerejeta/fix_nr_rows
branch
from
c26b960 to
4084b80
Compare
Unfortunately the wasm backend makes a breaking change. We need newer version to support bumpalo
John-Gong-Math
approved these changes
Apr 1, 2024
iquerejeta
added a commit
that referenced
this pull request
May 8, 2024
Add support for Pluto / Eris
dkaidalov
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Compare polynomials and polynomial commitments by reference. Issue #1 Not permit duplicate queries Issue #3 * Add Length of PIs to the transcript Issue #2 * Check trailing bytes Issue #6 * Panic if two points are equals in lagrange_interpolate. Issue #10 * Hash the byte representation of the VK in the transcript Issue #5 We do not add the architecture, as the verifier is already parametrised by that. * Consistency in polynomial multiplication Issue #7 We mutate the polynomial (with all zeroes) to be consistent with the behaviour. * Make commitment homomorphic, and don't send evals of pieces - Issue#0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some regions might have no rows (if the lookup table is empty, or if it only contains equality constraints).
We missed that when counting the number of rows.