Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Mar 27, 2023

This PR was implemented using the following steps:

  1. In intel/llvm: remove current limited subset of end-to-end tests in sycl/test-e2e/ directory
  2. Create a fresh clone of intel/llvm-test-suite and filter it using https://github.com/newren/git-filter-repo with the following command:
git-filter-repo --path SYCL  --message-callback 'return re.sub(b"\\(#([0-9]+)\\)", b"(intel/llvm-test-suite#\\1)", message)'
  1. In the filtered repo, perform
$ git mv SYCL sycl/test-e2e && git commit -m "Move SYCL -> sycl/test-e2e"
  1. Return back to intel/llvm, add filtered repo as a remote and merge it in. It resulted in two conflicts in CMakeLists.txt and lit.site.cfg.py.in. The resolution is to keep intel/llvm version with an additional change of uncommenting previously skipped add_subdirectory(External) and add_subdirectory(ExtraTests) in CMakeLists.txt.
  2. Update sycl/test-e2e/README.md

kbobrovs and others added 30 commits November 14, 2022 11:01
…llvm-test-suite#1359)

Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
* add tests for a bunch of fp16 utils
* add check for platform without fp16 support

Signed-off-by: jinge90 <ge.jin@intel.com>
While extending the original test did some refactoring:
1. Reduced types it tests
2. Test only 1 and 2 dimensions
…est-suite#1396)

CUDA and HIP BE do not support intel::reqd_sub_group_size, so it's not
possible to control sub-group size which is needed to get the size of
temporary memory for sort algorithm.
…est-suite#1387)

intel#7401 fixes host-side minimal
subnormal half values, which in turn fixes generate_ref_conv_data
in value_conv.hpp. This causes ctor_broadcast_fp_extra to unexpectedly
pass. This commit enables ctor_broadcast_fp_extra.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
[SYCL] Fix type

Signed-off-by: Rauf, Rana <rana.rauf@intel.com>
…lvm-test-suite#1400)

Copy-pasted from reduction_nd_N_vars.cpp and adjusted to use
sycl::range.
Also added a try catch block to print possible "synchronous" exceptions.
…suite#1373)

That way we can bypass strategy selection and test any of them with the
same type/operation.
…uite#1401)

ctor_broadcast_fp_extra uses fp16 and fp64 but does not check for the
requirement before running the kernels on the device. This commit adds
the requirement check to ctor_broadcast.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
…ite#1404)

Two simple tests to check that code using the kernel fusion extension API compiles correctly. 

The tests currently do not yet execute the compiled application, as the necessary functionality will only be added to the implementation in a later PR. 

Spec: intel#7098
Implementation: intel#7416

Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
…ntal status. (intel/llvm-test-suite#1129)

Tests changes for intel#6524

Signed-off-by: Rajiv Deodhar <rajiv.deodhar@intel.com>
Co-authored-by: JackAKirk <jack.kirk@codeplay.com>
…l/llvm-test-suite#1398)

* [ESIMD] Separate ieee sqrt/div functions from ext_math.cpp test

This patch:
- separates the ieee_sqrt() and ieee_div() test cases to a new test,
  which is not started on Gen12 because it doesn't support those
  operations even for fp32.
- enables ext_math.cpp on Windows.

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…vm-test-suite#1422)

intel#6524 moved bfloat16 out of the
experimental namespace. This commit removes the last remaining uses
of the experimental namespace in bfloat16 for ESIMD and matrix tests.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
…on (intel/llvm-test-suite#1365)

This test is expected to throw an exception so we need to disable the ZE_DEBUG test.

Signed-off-by: Byoungro So byoungro.so@intel.com
…est-suite#1423)

* [SYCL][CUDA] Add SM version check to bfloat16 CUDA test

bfloat16 requires SM80 on the CUDA backend. This commit changes CUDA
tests to do an early exit if that requirement is not met.
* Remove CUDA specific test and try run SM80

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
* [SYCL] Fix CUDA tests using bfloat16
* Add missing using in element_wise_wi_marray_legacy

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This commit should fix the is_compatible test for non-SPIRV targets.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
sarnex and others added 7 commits March 24, 2023 11:57
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Co-authored-by: Vyacheslav Klochkov <vyacheslav.n.klochkov@intel.com>
…st-suite#1695)

Revert "[SYCL] Refactor invalid use of local accessor (intel/llvm-test-suite#1646)"

This reverts commit c257c0b.
…te#1679)

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
…-test-suite#1685)

This patch updates the E2E tests to account for the changes made to aspects in [Section 4.6.4.3](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:device-aspects) of the specification:

- The concept of a "host" device no longer exists in SYCL 2020 - any `host` should now be a `cpu`, so the aspect has been deprecated accordingly.
- `usm_restricted_shared_allocations` has been removed.
- `usm_system_allocator` has been renamed `usm_system_allocations`.
- `int64_*` aspects were replaced with `atomic64`, so no longer should be tested.
We're doing the final move and it makes sense to make a "clean"
merge (except that CMake/LIT config stuff that had some customizations).
@aelovikov-intel aelovikov-intel requested review from a team as code owners March 27, 2023 15:42
@aelovikov-intel aelovikov-intel added the disable-lint Skip linter check step and proceed with build jobs label Mar 27, 2023
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 27, 2023 18:59 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 27, 2023 20:24 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel requested a review from bader March 27, 2023 20:58
v-klochkov and others added 2 commits March 27, 2023 17:03
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@bader bader changed the title Move intel/llvm-test-suite SYCL tests to in-tree sycl/test-e2e [SYCL] Move intel/llvm-test-suite SYCL tests to in-tree sycl/test-e2e Mar 27, 2023
@bader bader merged commit ee211b6 into intel:sycl Mar 27, 2023
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 27, 2023 23:25 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel temporarily deployed to aws March 28, 2023 00:48 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel deleted the final-test-move branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disable-lint Skip linter check step and proceed with build jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.