Skip to content

chore(ci): pin github actions to commit shas - #4630

Merged
thetaPC merged 1 commit into
mainfrom
pins
Aug 11, 2026
Merged

chore(ci): pin github actions to commit shas#4630
thetaPC merged 1 commit into
mainfrom
pins

Conversation

@thetaPC

@thetaPC thetaPC commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Issue URL: N/A

What is the current behavior?

The workflow references its GitHub Actions by floating major tags, actions/checkout@v4 and actions/setup-node@v4. A tag is mutable, so whoever controls the action repository can repoint it at different code, and every subsequent CI run picks that code up with no change on our side. This is the supply chain risk behind the recent run of compromised action releases.

Renovate is also scoped to the stackblitz sample apps only, via includePaths, so nothing under .github/workflows is visible to it.

What is the new behavior?

Both actions are pinned to a full commit SHA, with the version in a trailing comment for readability. A SHA is immutable, so CI runs the exact code that was reviewed. The SHAs and the comment format match what ionic-framework already uses, keeping the two repos consistent:

  • actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
  • actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0

.github/workflows/** is added to includePaths in renovate.json. This is required rather than optional: a pin that is never bumped stops receiving security patches, which would leave us worse off than the floating tags.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-docs Ready Ready Preview Aug 11, 2026 5:27pm

Request Review

@thetaPC
thetaPC marked this pull request as ready for review August 11, 2026 17:39
@thetaPC
thetaPC requested a review from a team as a code owner August 11, 2026 17:39
@thetaPC
thetaPC requested review from ShaneK and gnbm August 11, 2026 17:39

@gnbm gnbm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC
thetaPC merged commit f8cd04b into main Aug 11, 2026
4 checks passed
@thetaPC
thetaPC deleted the pins branch August 11, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants