Skip to content

fix(list): add bottom border for last select item #12690

Closed
marcovtwout wants to merge 96 commits intoionic-team:masterfrom
marcovtwout:patch-1
Closed

fix(list): add bottom border for last select item #12690
marcovtwout wants to merge 96 commits intoionic-team:masterfrom
marcovtwout:patch-1

Conversation

@marcovtwout
Copy link

@marcovtwout marcovtwout commented Aug 17, 2017

Fixes #12689

brandyscarney and others added 30 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (ionic-team#12015)
47e3c70 
fixes ionic-team#10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes ionic-team#9699
fixes ionic-team#11484
fixes ionic-team#11389
fixes ionic-team#11325
fixes ionic-team#11291
fixes ionic-team#10828
fixes ionic-team#11291
fixes ionic-team#10393
fixes ionic-team#10257
fixes ionic-team#9434
fixes ionic-team#8933
fixes ionic-team#7178
fixes ionic-team#7047
fixes ionic-team#10552
fixes ionic-team#10393
fixes ionic-team#10183
fixes ionic-team#10187
fixes ionic-team#10852
fixes ionic-team#11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes ionic-team#11745
fixes ionic-team#11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…ionic-team#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (ionic-team#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (ionic-team#12043)
7a1342c 
fixes ionic-team#7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (ionic-team#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (ioni…
c7645ee 
…c-team#11965)

fixes ionic-team#6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes ionic-team#12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes ionic-team#11988
@AmitMY @manucorporat
feat(item-reorder): add side support (ionic-team#11642)
63f728f 
fixes ionic-team#11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (ionic-team#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes ionic-team#12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@danbucholtz
chore(build): strictly enforce metadata
00fbded
danbucholtz and others added 22 commits July 14, 2017 11:55
@danbucholtz
chore(dependencies): add angular/tsc-wrapper to package.json to avoid…
ab511c4 
… npm issues people are having
@danbucholtz
chore(dependencies): removing tsc-wrapped since angular explicitely s…
cec718c 
…ays not to do this
@danbucholtz
chore(dependencies): update the lock file
c4e7552
@danbucholtz
chore(changelog): 3.5.3 release
5b9fe5e
@samuelgoodell @perrygovier
chore(docs): add anchor links to documentation sub-sections (ionic-te…
961bfc3 
…am#12386)

* chore(docs): add anchor links to documentation sub-sections

* chore(docs): make entire section headings clickable as anchors
@brandyscarney
fix(list): remove margin of MD buttons in ion-item-options (ionic-tea…
97f9522 
…m#12263)
@danbucholtz
fix(navigation): reduce urls to minimum set of fields
a8ceee4 
* wip

* simple-nav, simple-tabs, simple-nav-then-tabs, simple-nested-navs all pass w00t w00t

* updates

* fix tests

* update test
@danbucholtz
chore(karma): fix duplicate console.log issue
519d657
@danbucholtz
fix(navigation): fix bug where that occurred when tab identifier and …
add0c4e 
…segment had the exact same string
@mhartington
feat(generators): refactor generators
400aa54 
* feat(generators): update templates

* feat(generators): add pipeName to templates
@danbucholtz
fix(navigation): account for race conditions in developer's code
4596dbe
@danbucholtz
fix(nav): make call to setPages return the promise so if it rejects i…
de0f9d5 
…t doesn't get lost
@danbucholtz
fix(navigation): fix null pointer exceptions that would occur when de…
584afd0 
…stroying a nav controller while its transitioning
@danbucholtz
chore(changelog): 3.6.0 changelog
16f2ebe
@danbucholtz
chore(changelog): change --save to --save-dev for app-scripts
e401997
@danbucholtz
chore(changelog): add details about tabUrlPath to changelog
f605f0a
@kelvindart @manucorporat
docs(input): correct the autocomplete and autocorrect description (…
50beafa 
…ionic-team#12613)
@imhoffd
fix(generators): Update documentation URLs for templates
475b722 
fixes ionic-team/ionic-cli#2622
@perrygovier
chore(CI): ignore refactor branches
17b3a39
@perrygovier
chore(CI): don’t need to ingore core/overlay branch
1e9539b
@perrygovier
chore(CI): branches property must be a child of build
26b09f1
@marcovtwout
Fix border if last list item is <ion-select>
d772c29
@AmitMY
Copy link
Contributor

AmitMY commented Aug 17, 2017

Is this an issue with ios and wp as well?

@marcovtwout
Copy link
Author

marcovtwout commented Aug 21, 2017

@AmitMY I don't think so (the original input css blames from #9679, which notes this is not an issue for ios/wp).

@brandyscarney brandyscarney changed the title Fixes #12689 fix(list): add bottom border for last select item Aug 31, 2017
@Ionitron
Copy link
Collaborator

Ionitron commented Mar 12, 2018

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.