Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The searchbar screenshot test is flaky due to the rendering of an animated searchbar at the bottom of the screenshot.

What is the new behavior?

  • Broke the screenshot test up into several smaller screenshots to a) de-duplicate tests, b) reduce screenshot size, and c) improve stability of tests to avoid async rendering (such as with the animated searchbar).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 9, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review December 9, 2022 15:36
@liamdebeasi liamdebeasi requested a review from a team as a code owner December 9, 2022 15:36
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a list screenshot update that snuck in, but otherwise this LGTM.

@liamdebeasi
Copy link
Contributor Author

Good catch! Fixing that in #26458.

@liamdebeasi liamdebeasi merged commit 8122494 into main Dec 9, 2022
@liamdebeasi liamdebeasi deleted the search-tests branch December 9, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants