Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The inset list test takes a screenshot of the entire page. Occasionally, there is a 1px diff detected in the same location on the page.

What is the new behavior?

  • By taking a screenshot of a single component, we should be able to avoid this 1px diff.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 9, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review December 9, 2022 16:43
@liamdebeasi liamdebeasi requested review from a team as code owners December 9, 2022 16:43
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshotting the list directly doesn't capture the margin that the inset property adds. Would it be possible to wrap the list in a separate container and screenshot that instead?

@liamdebeasi liamdebeasi merged commit 340dd13 into main Dec 9, 2022
@liamdebeasi liamdebeasi deleted the list-flaky branch December 9, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants