chore: sync with main #28884
Merged
chore: sync with main #28884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: resolves #28716 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> All components that have per-mode stylesheets can have their mode adjusted by setting `mode` on the component. We use the `setMode` function to determine which mode to use on the component: https://github.com/ionic-team/ionic-framework/blob/516b84475e5d78060f35fa2c4821efc712536353/core/src/global/ionic-global.ts#L75 While this works on refresher, it is missing the `virtualProp` jsdoc comment which causes it to not have the appropriate type information. As a result, when developers try to use a JS binding for `mode`, they will get compilation errors. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds virtualProp for mode to refresher ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> I am considering this a bug fix instead of a feature. In non-TypeScript environments you can set `mode` on `ion-refresher` and it does change the mode. What's missing here is the type information associated with it. Dev build: `7.6.2-dev.11702914017.1ae72da5`
#28713) Bumps [@capacitor/keyboard](https://github.com/ionic-team/capacitor-plugins) from 5.0.6 to 5.0.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor-plugins/releases"><code>@capacitor/keyboard</code>'s releases</a>.</em></p> <blockquote> <h2><code>@capacitor/keyboard</code><a href="https://github.com/5"><code>@5</code></a>.0.7</h2> <h2><a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.6...@capacitor/keyboard@5.0.7">5.0.7</a> (2023-12-15)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>keyboard:</strong> Change keyboard style during setStyle (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1935">#1935</a>) (<a href="https://github.com/ionic-team/capacitor-plugins/commit/3b520b845563f08897f55eb44fe212ae384a7675">3b520b8</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/c5aab483fe0609ab1b2503c245a6c27b6cfd5a7b"><code>c5aab48</code></a> chore(release): publish [skip ci]</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/77dc373b41fb5fee9fb7acdb511564043494bb10"><code>77dc373</code></a> fix(camera): reject promise on web input cancel event (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1964">#1964</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/bf7ec3306e7943358ac9ea118b904ff27d6ea2f6"><code>bf7ec33</code></a> feat(google-maps): Separate mapId for Google Maps Cloud IDs (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1943">#1943</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/3b520b845563f08897f55eb44fe212ae384a7675"><code>3b520b8</code></a> fix(keyboard): Change keyboard style during setStyle (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1935">#1935</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/e18f45853322516c2da8c8505814deb72a5eaecc"><code>e18f458</code></a> docs(screen-reader): Use stateChange event in example code (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1934">#1934</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/fb941c7f39c37684c07c5162644756f4b919418d"><code>fb941c7</code></a> feat(filesystem): add removeAllListeners method (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1868">#1868</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/3d20522a7d4ecf678ce9e0dded9af3065235c817"><code>3d20522</code></a> chore(ci): Pin <code>@actions/http-client</code> version to 2.1.1 (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1870">#1870</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/dc2eb14b7d8db3c5a178c420a0fd37209b97912d"><code>dc2eb14</code></a> chore(release): publish [skip ci]</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/73ad64b665406d028cf2e171da89801a0ea9cf78"><code>73ad64b</code></a> fix(google-maps): use URLSession for remote iconUrl on iOS (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1818">#1818</a>) (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1824">#1824</a>)</li> <li><a href="https://github.com/ionic-team/capacitor-plugins/commit/ef656564518d03624d5d74a3ca173a53594ec4ba"><code>ef65656</code></a> fix(google-maps): Apply iconAnchor value to Marker anchor on Android (<a href="https://redirect.github.com/ionic-team/capacitor-plugins/issues/1822">#1822</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/capacitor-plugins/compare/@capacitor/keyboard@5.0.6...@capacitor/keyboard@5.0.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Release 7.6.2
After each release, we need to update the local `package-lock.json` dependencies. We do this via a `npm install --package-lock-only` command. However, this command can fail for reasons such as a connection timeout. When this happens, the package-lock files do not get updated. The problem is this action is also done in the same job as generating the changelog and creating the GitHub release. This operations cannot be re-done. As a result, we cannot simply re-run this job and try updating the package-lock files again. This PR changes the workflow to split the package-lock update out to its own job. In the event that this job fails, we can re-run only this job and leave the other jobs untouched.
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28694 there was some confusion around how to access `this` inside of a callback function passed to a property on Ionic components. The root issue was due to how the `this` context is determined with developers being responsible for setting the appropriate `this` context. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - While this isn't an Ionic bug, I think it's worth calling out this behavior so developers are aware of how to account for it. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Note: The link in the docs will not work until ionic-team/ionic-docs#3333 is merged. --------- Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We removed the background color from today's calendar day button if selected when implementing the calendar-day button shadow part feature: 79b005d#diff-8e2912d52559aa44c9c6dc062c8d683e7b51c92c7b7ba420ad6f7587f1e1a61aL139 We did not catch this because we do not have test coverage for this use case. We typically avoid rendering datetime on today's date because "today" could be something totally different depending on the test machine's locale/configuration. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds the background rule that was removed - Added test coverage. I mocked today's date to be a fixed date so it never changes ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: ionitron <hi@ionicframework.com>
Issue number: resolves #28617 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We currently check to see if `webkitOverflowScrolling` is supported on the refresher's style object in order to enable to native iOS refresher. This works well for iOS, but it does not work for iPadOS. This is because this property was removed in iPadOS 13: https://developer.apple.com/documentation/safari-release-notes/safari-13-release-notes > Disabled -webkit-overflow-scrolling: touch on iPad. All frames and scrollable overflow areas now use accelerated one-finger scrolling without changing stacking. As a result, the native iOS refresher does not activate on iPadOS. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - I think it's safe to assume that `webkitOverflowScrolling` may be removed on iOS in the future too since it was already removed on iPadOS. As a result, I implemented a solution that avoids checking this. - The `CSS.supports` check is required because otherwise the native iOS refresher would be activated in an emulated environment such as Chrome dev tools because the user agent is spoofed. The `apple-pay-logo-black` named image is only supported on Apple devices. Risks: - Apple could remove the `apple-pay-logo-black` named image in the future. However, we currently use this check elsewhere in Ionic too and it has worked well: https://github.com/ionic-team/ionic-framework/blob/60303aad23f823488afc8f8824e9c72e3ab86acc/core/src/components/datetime/datetime.ios.scss#L177. - Apple could add touch emulation to desktop Safari which could cause the native refresher to activate when using responsive design mode for testing. However, this would only impact app developer and would not impact production use cases. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.5.8-dev.11703088210.14a72b83` Co-authored-by: Sean Perkins <sean-perkins@users.noreply.github.com> --------- Co-authored-by: Sean Perkins <sean-perkins@user.noreply.github.com>
Bumps [ionicons](https://github.com/ionic-team/ionicons) from 7.2.1 to 7.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/ionicons/releases">ionicons's releases</a>.</em></p> <blockquote> <h2>v7.2.2</h2> <h2><a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">7.2.2</a> (2023-12-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>icon:</strong> add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>) (<a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc">d582e62</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/ionicons/blob/main/CHANGELOG.md">ionicons's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">7.2.2</a> (2023-12-13)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>icon:</strong> add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>) (<a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc">d582e62</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/ionicons/commit/fccc2606274ac79c420a15df210e9649449a2acb"><code>fccc260</code></a> v7.2.2</li> <li><a href="https://github.com/ionic-team/ionicons/commit/d582e6208e626722e4350426a509a6870e90a0bc"><code>d582e62</code></a> fix(icon): add better warning when loading icons (<a href="https://redirect.github.com/ionic-team/ionicons/issues/1297">#1297</a>)</li> <li><a href="https://github.com/ionic-team/ionicons/commit/625d54fdada2947957d468a89c65a27bd79aa670"><code>625d54f</code></a> merge release-7.2.1</li> <li><a href="https://github.com/ionic-team/ionicons/commit/841fb965437fc6ca30d953179ff139621b8aafd6"><code>841fb96</code></a> remove duplicate entry</li> <li><a href="https://github.com/ionic-team/ionicons/commit/9dab13aef7402ccf4d9ea76ccf0175d0dd13a663"><code>9dab13a</code></a> chore(): update package lock files</li> <li>See full diff in <a href="https://github.com/ionic-team/ionicons/compare/v7.2.1...v7.2.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The keyboard navigation tests for radio were disable due to flakiness with Safari when it came to the CI. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Re-enabled the tests. Debugging was done with a saved artifact. The artifact didn't provide a clear reason of why it flakes. But it did seem that the test was tabbing before the Safari page finished loading. I've added a `waitFor()` to verify that the radios have rendered. This was done for Safari only to prevent any additional wait time. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> There is no great way to test this since it only flakes on GitHub.
) Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 3.0.7 to 3.0.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil-sass/releases"><code>@stencil/sass</code>'s releases</a>.</em></p> <blockquote> <h2>v3.0.8</h2> <h2>What's Changed</h2> <ul> <li>chore(deps): update actions/setup-node action to v3.8.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/423">ionic-team/stencil-sass#423</a></li> <li>chore(deps): update actions/setup-node action to v4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/425">ionic-team/stencil-sass#425</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.6.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/424">ionic-team/stencil-sass#424</a></li> <li>chore(deps): update node.js to v20.9.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/426">ionic-team/stencil-sass#426</a></li> <li>chore(deps): update dependency rollup to v4.1.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/427">ionic-team/stencil-sass#427</a></li> <li>chore(deps): update dependency rollup to v4.1.6 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/430">ionic-team/stencil-sass#430</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/428">ionic-team/stencil-sass#428</a></li> <li>chore(deps): update dependency terser to v5.23.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/429">ionic-team/stencil-sass#429</a></li> <li>chore(deps): update dependency terser to v5.24.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/433">ionic-team/stencil-sass#433</a></li> <li>chore(deps): update dependency rollup to v4.2.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/432">ionic-team/stencil-sass#432</a></li> <li>chore(deps): update dependency npm to v10.2.3 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/431">ionic-team/stencil-sass#431</a></li> <li>chore(deps): update dependency rollup to v4.3.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/434">ionic-team/stencil-sass#434</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/435">ionic-team/stencil-sass#435</a></li> <li>chore(deps): update dependency rollup to v4.3.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/436">ionic-team/stencil-sass#436</a></li> <li>chore(deps): update dependency rollup to v4.4.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/437">ionic-team/stencil-sass#437</a></li> <li>chore(deps): update dependency prettier to v3.1.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/438">ionic-team/stencil-sass#438</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.7.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/439">ionic-team/stencil-sass#439</a></li> <li>chore(deps): update dependency rollup to v4.4.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/440">ionic-team/stencil-sass#440</a></li> <li>chore(deps): update dependency npm to v10.2.4 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/441">ionic-team/stencil-sass#441</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/444">ionic-team/stencil-sass#444</a></li> <li>chore(deps): update dependency np to v9 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/445">ionic-team/stencil-sass#445</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.1 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/446">ionic-team/stencil-sass#446</a></li> <li>chore(deps): update dependency terser to v5.25.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/447">ionic-team/stencil-sass#447</a></li> <li>chore(deps): update dependency np to v9.1.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/449">ionic-team/stencil-sass#449</a></li> <li>chore(deps): update dependency npm to v10.2.5 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/448">ionic-team/stencil-sass#448</a></li> <li>chore(deps): update dependency terser to v5.26.0 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/450">ionic-team/stencil-sass#450</a></li> <li>chore(deps): update dependency <code>@stencil/core</code> to v4.8.2 by <a href="https://github.com/renovate"><code>@renovate</code></a> in <a href="https://redirect.github.com/ionic-team/stencil-sass/pull/453">ionic-team/stencil-sass#453</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8">https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil-sass/commit/5132964c48fa825bcc5e9e29502fbf034cb7ec9d"><code>5132964</code></a> 3.0.8</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/9709fe24358967aee291cbc51a73c76e964f4717"><code>9709fe2</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.2 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/453">#453</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/59591b16a3b68927e76faa5165d973a0192a47ea"><code>59591b1</code></a> chore(deps): update dependency terser to v5.26.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/450">#450</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/cc7d97f7d9db4825d076bbb0a8c04fe93b362352"><code>cc7d97f</code></a> chore(deps): update dependency npm to v10.2.5 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/448">#448</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/838cd61da74b372e67351e2725b43186a79f2428"><code>838cd61</code></a> chore(deps): update dependency np to v9.1.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/449">#449</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/e53802422ed0f56c89b860672f1ac297291b83be"><code>e538024</code></a> chore(deps): update dependency terser to v5.25.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/447">#447</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/4d7ff18177b2b5fdef34df42c9c9233570934d4c"><code>4d7ff18</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.1 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/446">#446</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/f9b99826dbe80524f08092f52f878a390b1af5d9"><code>f9b9982</code></a> chore(deps): update dependency np to v9 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/445">#445</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/b4d8158a986a11ea38d757f498c243a3c489cfff"><code>b4d8158</code></a> chore(deps): update dependency <code>@stencil/core</code> to v4.8.0 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/444">#444</a>)</li> <li><a href="https://github.com/ionic-team/stencil-sass/commit/d2864095215f2f26232307f41850f5919b5e9aaa"><code>d286409</code></a> chore(deps): update dependency npm to v10.2.4 (<a href="https://redirect.github.com/ionic-team/stencil-sass/issues/441">#441</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil-sass/compare/v3.0.7...v3.0.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…28706) Bumps [@capacitor/core](https://github.com/ionic-team/capacitor) from 5.5.1 to 5.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/releases"><code>@capacitor/core</code>'s releases</a>.</em></p> <blockquote> <h2>5.6.0</h2> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">5.6.0</a> (2023-12-14)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0">1d948d4</a>)</li> <li><strong>http:</strong> properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>) (<a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382">a745a89</a>)</li> <li><strong>http:</strong> set formdata boundary and body when content-type not explicitly set (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7133">#7133</a>) (<a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60">3862d6e</a>)</li> <li><strong>ios:</strong> add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>) (<a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7">5fb902b</a>)</li> </ul> <h3>Features</h3> <ul> <li>support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>) (<a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02">421d2c0</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/blob/5.6.0/CHANGELOG.md"><code>@capacitor/core</code>'s changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">5.6.0</a> (2023-12-14)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>) (<a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0">1d948d4</a>)</li> <li><strong>http:</strong> properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>) (<a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382">a745a89</a>)</li> <li><strong>http:</strong> set formdata boundary and body when content-type not explicitly set (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7133">#7133</a>) (<a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60">3862d6e</a>)</li> <li><strong>ios:</strong> add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>) (<a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7">5fb902b</a>)</li> </ul> <h3>Features</h3> <ul> <li>support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>) (<a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02">421d2c0</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor/commit/12cdab84fcc28a28bc0ca493298fd8e13a53ea4e"><code>12cdab8</code></a> Release 5.6.0</li> <li><a href="https://github.com/ionic-team/capacitor/commit/421d2c02e4d1954d16d573facae9c235fee60f02"><code>421d2c0</code></a> feat: support for Amazon Fire WebView (<a href="https://redirect.github.com/ionic-team/capacitor/issues/6603">#6603</a>) (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7129">#7129</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/a745a89e18a5082ae4e737d78aa20929f6952382"><code>a745a89</code></a> fix(http): properly write form-urlencoded data on android request body (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7130">#7130</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/dfc97ee2d87e70fb94f3e92bb30d0ae8f9a9eafa"><code>dfc97ee</code></a> docs(http): FormData and other complex types do not work on CapacitorHttp plu...</li> <li><a href="https://github.com/ionic-team/capacitor/commit/3862d6e6721793d78add9acf5b14fd9a8f7a5b60"><code>3862d6e</code></a> fix(http): set formdata boundary and body when content-type not explicitly se...</li> <li><a href="https://github.com/ionic-team/capacitor/commit/5fb902b232d9afded2edc865c8d3c0c0e7efe5e7"><code>5fb902b</code></a> fix(ios): add some new cordova-ios classes used by Cordova plugins (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7115">#7115</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/7977a6da4876b1a9ee1b1a532f84789ec37c3c74"><code>7977a6d</code></a> chore(android): Update json test dependency (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7102">#7102</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/13935f0c3bf87d5220bcdb5759c109edb841d9b5"><code>13935f0</code></a> docs: add warning around androidScheme with Android webview 117 (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7098">#7098</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/8d97b800ca2d3b5f4e3485cbbbcd747b94c8bf0b"><code>8d97b80</code></a> chore(android): Mock Log class for tests (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7099">#7099</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/1d948d4df6b6b6f8cfdc02e72d84ae8be963f4a0"><code>1d948d4</code></a> fix(cli): Use latest native-run (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7030">#7030</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/capacitor/compare/5.5.1...5.6.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…arger screens (#28745) Issue number: resolves #28737 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28246 we removed the overflow on Nav and Router Outlet to allow content to flow outside of these containers. This allows the translucent tab effect to work (otherwise content would be clipped and there would be no translucency). However, this had the unintended side effect of causing page transitions to flow outside of these components. This is most noticeable on larger displays when using SplitPane because the page can cover the menu mid-transition. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Overflow is no longer allowed on the main content. I originally set the overflow on the router outlet/nav itself, but that caused the translucent tab bar behavior to regress. Since this issue only happens with split pane, I decided to apply the fix there. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> ### Dev build `7.6.3-dev.11703103144.148eb1f6`⚠️ Please test in a physical app too ### Before/After Demo | `main` | branch | | - | - | | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/2f3f0d74-9a7e-4ebe-b58a-6e1a6ea3636e"></video> | <video src="https://github.com/ionic-team/ionic-framework/assets/2721089/cdbf8fb5-e217-48cf-8c1e-4bdecee4de4c"></video> | ### Screenshot Diffs The `menu-custom` screenshot diffs ([Example](https://github.com/ionic-team/ionic-framework/pull/28745/files)) are correct. By adding `overflow: hidden`, the box shadow from the "Content" header no longer flows outside of the container. The menu [border on MD has an opacity of 0.18](https://github.com/ionic-team/ionic-framework/blob/e5226016a0f0b066a7bd7fc9997f905d3b87fbc4/core/src/components/menu/menu.md.vars.scss#L7), so the border color was mixing with the color of the box shadow from the header. Since the shadow no longer flows outside of the container, the border color does not mix with the box shadow color. ### Does this break translucent tabs when the split pane is inside of a tab? No. The [split pane has `contain: strict` set](https://github.com/ionic-team/ionic-framework/blob/e5226016a0f0b066a7bd7fc9997f905d3b87fbc4/core/src/components/split-pane/split-pane.scss#L24) which prevents content from flowing under the tab bar, so the translucent tab bar never worked with this layout. --------- Co-authored-by: ionitron <hi@ionicframework.com>
This PR begins holiday triage mode for the Ionic Framework repo.
Issue number: resolves #28677 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Defining disabled a `@Prop() disabled = false` causes Stencil to mark this property as optional. This behavior is not desired on our end, but making the property required would be a breaking change. Additionally, the root issue is due to how Stencil resolves types. For example, `disabled` is [optional in the LocalJSX namespace](https://github.com/ionic-team/ionic-framework/blob/e96a1457a32646fa23c8218cb3cca4a8215ad115/core/src/components.d.ts#L6921) but [required in the Components namespace](https://github.com/ionic-team/ionic-framework/blob/e96a1457a32646fa23c8218cb3cca4a8215ad115/core/src/components.d.ts#L2239). Addressing this inside of Stencil is significant breaking change. As a result, the team has decided to compromise and support the falsy `disabled` state for radio for now. Other Ionic components that support the `disabled` prop also check for falsy values. Stencil plans to de-risk this in https://ionic-cloud.atlassian.net/browse/STENCIL-917. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Radio Group now looks at falsy values instead of strictly checking `false`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.2-dev.11703182244.1165aeec`
Release 7.6.3
Issue number: resolves #28762 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Focused inputs have `pointer-events: none`. This code was added in e27452b to address #5536. However, this causes slotted buttons to not be clickable when the input is focused because pointer events have been removed. This also causes the input to blur whenever you tap the label text. This behavior only exists on `ion-input`. Textarea is not affected. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This code was added several years ago for the (now) legacy syntax. I don't have full confidence that this won't break the legacy input because there's not a lot of context around why specifically this code was added. As a result, I scoped these styles only to the legacy input. - Slotted buttons can now be clicked when the input is focused. - Tapping the label when an input is focused keeps the input focused. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> **Testing:** 1. I manually verified that scroll assist still works with the modern input. 2. I manually verified that the input remains focused after tapping the label. Dev build: `7.6.3-dev.11704229014.12cdc767`
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> As part of FW-2832 the team has an initiative to remove much of the `any` usage in favor of stronger types. This will make modifications to this codebase safer as we will have access to proper type checking. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removed several `any` usages in favor of stronger types. Note that not all of the `any` types within these files have been removed. I mainly stuck to the low hanging fruit 😄 ## Does this introduce a breaking change? - [ ] Yes - [x] No I intentionally made type changes that do not impact public APIs. Any incorrect type changes would cause our CI checks to fail. <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.8.2 to 4.9.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🐏 v4.9.0 (2023-12-18)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> fix transforming method parameters into docs (<a href="https://redirect.github.com/ionic-team/stencil/issues/5166">#5166</a>) (<a href="https://github.com/ionic-team/stencil/commit/2d16db6d6e7b1b9559c895d3c7a0970207c0df7f">2d16db6</a>)</li> <li><strong>mock-doc:</strong> add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>) (<a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d">6233cb5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3382">#3382</a></li> <li><strong>runtime:</strong> allow setting <code>key</code> attr on nested Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5164">#5164</a>) (<a href="https://github.com/ionic-team/stencil/commit/f6903a86caec1dda655290d99eaf8c42a8e102ac">f6903a8</a>)</li> <li><strong>runtime:</strong> patch <code>removeChild</code> for <code>scoped</code> components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5148">#5148</a>) (<a href="https://github.com/ionic-team/stencil/commit/956c19651772ce1770598e605b6c50e20b39cefa">956c196</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3278">#3278</a></li> <li><strong>screenshot:</strong> reject pixel match process on exit (<a href="https://redirect.github.com/ionic-team/stencil/issues/5167">#5167</a>) (<a href="https://github.com/ionic-team/stencil/commit/c2ee40db4b515224376b94019067de896d2f1a24">c2ee40d</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> Stencil decorator import aliasing (<a href="https://redirect.github.com/ionic-team/stencil/issues/5161">#5161</a>) (<a href="https://github.com/ionic-team/stencil/commit/97dcb45d44751d239b0afb6380bea217818b211a">97dcb45</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3137">#3137</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🐏 <a href="https://github.com/ionic-team/stencil/compare/v4.8.2...v4.9.0">4.9.0</a> (2023-12-18)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> fix transforming method parameters into docs (<a href="https://redirect.github.com/ionic-team/stencil/issues/5166">#5166</a>) (<a href="https://github.com/ionic-team/stencil/commit/2d16db6d6e7b1b9559c895d3c7a0970207c0df7f">2d16db6</a>)</li> <li><strong>mock-doc:</strong> add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>) (<a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d">6233cb5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3382">#3382</a></li> <li><strong>runtime:</strong> allow setting <code>key</code> attr on nested Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5164">#5164</a>) (<a href="https://github.com/ionic-team/stencil/commit/f6903a86caec1dda655290d99eaf8c42a8e102ac">f6903a8</a>)</li> <li><strong>runtime:</strong> patch <code>removeChild</code> for <code>scoped</code> components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5148">#5148</a>) (<a href="https://github.com/ionic-team/stencil/commit/956c19651772ce1770598e605b6c50e20b39cefa">956c196</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3278">#3278</a></li> <li><strong>screenshot:</strong> reject pixel match process on exit (<a href="https://redirect.github.com/ionic-team/stencil/issues/5167">#5167</a>) (<a href="https://github.com/ionic-team/stencil/commit/c2ee40db4b515224376b94019067de896d2f1a24">c2ee40d</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> Stencil decorator import aliasing (<a href="https://redirect.github.com/ionic-team/stencil/issues/5161">#5161</a>) (<a href="https://github.com/ionic-team/stencil/commit/97dcb45d44751d239b0afb6380bea217818b211a">97dcb45</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3137">#3137</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/448addc17b6e872513a5ad1c3b0c671e81c800e8"><code>448addc</code></a> v4.9.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5194">#5194</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/33e930ba1f3a168f697999671f103959b0bb8ee9"><code>33e930b</code></a> chore(repo): revert to artifact actions v3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5195">#5195</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d"><code>6233cb5</code></a> fix(mock-doc): add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/964c801c86ce35a75d3d7de39871c6c8fcc272fb"><code>964c801</code></a> chore(snc): resolve final build-finish error (<a href="https://redirect.github.com/ionic-team/stencil/issues/5186">#5186</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/5e9e629180cc3682c0df6446e0eab84f2ab8bd75"><code>5e9e629</code></a> chore(deps): update actions/download-artifact action to v4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5191">#5191</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/437ce62730b7ecebd4a536128ff12d093199fc3e"><code>437ce62</code></a> chore(deps): update dependency <code>@types/eslint</code> to v8.44.9 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5187">#5187</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/689fbb325f41d95a338a0ac907c46466b9c6d4d2"><code>689fbb3</code></a> chore(deps): update dependency <code>@rollup/plugin-json</code> to v6.1.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5190">#5190</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ccc0000252932cdfbd45f0f56e7bcef9ddd4e079"><code>ccc0000</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v46.9.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5188">#5188</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/908886d9467cabe644b6a041f93216c23daf96c0"><code>908886d</code></a> chore(deps): update dependency puppeteer to v21.6.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5189">#5189</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a9c073645216f7afa315c7a0de9601fe20a7c968"><code>a9c0736</code></a> chore(snc): fix some snc errors in puppeteer-emulate.ts (<a href="https://redirect.github.com/ionic-team/stencil/issues/5177">#5177</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.8.2...v4.9.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.9.0 to 4.9.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🍬 v4.9.1 (2024-01-08)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>declarations:</strong> bundle child_process type for portability (<a href="https://redirect.github.com/ionic-team/stencil/issues/5165">#5165</a>) (<a href="https://github.com/ionic-team/stencil/commit/59ecd9e82ae43e7db67c81959bc34afa0d852087">59ecd9e</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🍬 <a href="https://github.com/ionic-team/stencil/compare/v4.9.0...v4.9.1">4.9.1</a> (2024-01-08)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>declarations:</strong> bundle child_process type for portability (<a href="https://redirect.github.com/ionic-team/stencil/issues/5165">#5165</a>) (<a href="https://github.com/ionic-team/stencil/commit/59ecd9e82ae43e7db67c81959bc34afa0d852087">59ecd9e</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/be680c691049315c3fa7b9cefdd115489ffed381"><code>be680c6</code></a> v4.9.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5240">#5240</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1ee9641c9b96d14c13f0f07af9cd9d146f13b9a7"><code>1ee9641</code></a> chore(deps): update dependency <code>@types/eslint</code> to v8.56.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5233">#5233</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/acbaaa87ef7a26b72d983bdbe4d90b23da7a18a9"><code>acbaaa8</code></a> chore(deps): update dependency eslint-plugin-jest to v27.6.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5235">#5235</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/11f7fd23dc7b95f88f87489b428f026697a556f0"><code>11f7fd2</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v46.10.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5237">#5237</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/be8b4593c7280ef20a808d722a9de269de6a7070"><code>be8b459</code></a> chore(deps): update dependency esbuild to v0.19.11 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5224">#5224</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/8f80d5d34a3cb528427f8b673947def7ca8efb3d"><code>8f80d5d</code></a> chore(deps): update dependency cspell to v8.3.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5226">#5226</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/336a40c989947313a91e2ae4b362139a03657c16"><code>336a40c</code></a> chore(deps): update dependency dts-bundle-generator to ~9.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5227">#5227</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/533fb30746dfb76d8b418eaf07d9d016f5f10cf7"><code>533fb30</code></a> chore(deps): update dependency <code>@types/node</code> to v20.10.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5223">#5223</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e4f1c420e550d324a81fa4b86756955bd1104756"><code>e4f1c42</code></a> Compile pixel-match file correctly (<a href="https://redirect.github.com/ionic-team/stencil/issues/5199">#5199</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d4f790f5059636ff344f41015d8ae9da6b2b04a6"><code>d4f790f</code></a> chore(esbuild): ensure that output dirs are empty before we run esbuild (<a href="https://redirect.github.com/ionic-team/stencil/issues/5219">#5219</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.9.0...v4.9.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In #28697 I moved the package-lock work to its own step to lets us re-run that if it fails. However, I forgot to checkout the project files in that step, so there was no `package-lock.json` file to update [resulting in an error](https://github.com/ionic-team/ionic-framework/actions/runs/7398703880/job/20128761433).
The update-package-lock job did not configure Git credentials correctly. As a result, the job is unable to push the `package-lock.json` changes to the repo: https://github.com/ionic-team/ionic-framework/actions/runs/7476310958/job/20346663176 This PR configures the job with the correct credentials.
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> `ion-button` is being used as a way to open the alerts. It's not being used to test functionality. When `ion-button` is updated then the screenshots in the alert tests must be updated. This shouldn't happen when `ion-button` isn't necessary to have in these tests. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Replaced `ion-button` with `button` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A --------- Co-authored-by: ionitron <hi@ionicframework.com>
…re (#28834) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.8.2 to 4.8.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3">4.8.3</a> (2024-01-09)</h2> <h3>Bug Fixes</h3> <ul> <li>allow cjs version of packages to export a default value (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/943">#943</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/b5aee3424fe4d0fbc0b2065e9c0bc56ce4032755">b5aee34</a>)</li> <li>Update axe-core to v4.8.3 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/968">#968</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b">be9002c</a>)</li> <li>Update axe-core to v4.8.3 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/978">#978</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc">1c83740</a>)</li> <li><strong>webdriverio:</strong> fix types between v8 and <v8 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/962">#962</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/0511338017f52fba78c6ff3708f0c9e950e7a34e">0511338</a>)</li> <li><strong>webdriverio:</strong> work with <code>@wdio/globals</code> (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/882">#882</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/2e016b4e17cff09f158427862f2fd2134a62cbc6">2e016b4</a>)</li> <li><strong>webdriverjs:</strong> fix default commonJs export (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/927">#927</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/b07d38cc2d85c6127391686482abf762758dce34">b07d38c</a>)</li> </ul> <h3>Reverts</h3> <ul> <li>Revert "fix: Update axe-core to v4.8.3 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/968">#968</a>)" (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/977">#977</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e">0aff5d8</a>), closes <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/968">#968</a> <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/977">#977</a></li> <li>Revert "chore: merge master into develop (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/955">#955</a>)" (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/956">#956</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514">07e7d9e</a>), closes <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/955">#955</a> <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/956">#956</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/dequelabs/axe-core-npm/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In MD mode, items in an inset list currently receive their own border radius, separate from the border radius also applied to the inset list itself. The original intent was likely to ensure that the corners of the items don't spill out of the list. However, the item's border radius is no longer needed, for two reasons: 1. MD has since added top/bottom padding to their lists ([spec](https://m2.material.io/components/lists#specs)), which we've mirrored. This means the borders no longer line up anyway. 2. Even if a developer removes the list's vertical padding (we set it on the host [here](https://github.com/ionic-team/ionic-framework/blob/535b8ed72486a1e94125c72b12d5b447b630f8c4/core/src/components/list/list.md.scss#L9), so it's easy to overwrite), inset lists currently have `overflow: hidden` set [here](https://github.com/ionic-team/ionic-framework/blob/535b8ed72486a1e94125c72b12d5b447b630f8c4/core/src/components/list/list.scss#L20), so the list's border radius still applies correctly even with the items' border radius removed. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Item border radius in inset lists removed. When testing locally, you may find it useful to increase the MD border radius value [here](https://github.com/ionic-team/ionic-framework/blob/535b8ed72486a1e94125c72b12d5b447b630f8c4/core/src/components/list/list.md.vars.scss#L47) so it's easier to see. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 3. Update the BREAKING.md file with the breaking change. 4. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Issue number: resolves #28325 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When typing the time into the date picker pressing "Enter" does not close the on-screen keyboard. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Pressing "Enter" closes the on-screen keyboard ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Test:⚠️ While I have a test for this, please also test this on a physical Android device. 1. Go to `src/components/datetime/test/basic` 2. Open the time picker (in any of the date times) 3. Tap the time to open the keyboard 4. Press "Enter" on Android. Observe that the keyboard closes. Dev build: `7.6.6-dev.11705528328.1ef5e17b`
…fferent months are set (#28847) Issue number: resolves #28602 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> We animate to the new date when the value is changed, but we do not account for multiple selection. This behavior is valuable for when the value is set asynchronously on a different month than what it shown. However, this is confusing when there are multiple dates selected in different months, because we do not reasonably know which date to animate to. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Datetime no longer animates to the new value if more than one date is selected, and the selected dates aren't all in the same month. An alternative strategy would be to always animate unless one of the selected dates is in the month currently being viewed. However, this would still mean guessing at which value the user wants to see, which we are trying to avoid. Based on this PR: #28605 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com> --------- Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: resolves #28774 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are two issues causing Ionic Vue apps to not behave as intended with certain versions of Vue: 1. In Vue 3.3 a [breaking change shipped](vuejs/core#9916) that changes the default behavior of the `watch` inside of IonRouterOutlet to be a shallow watcher instead of a deep watcher. This caused the router outlet to not consistent re-render. While the change was later reverted by the Vue team, they expressed that the change [may re-land in a future minor release](vuejs/core#9965 (comment)). As a result, we will need to account for this inside of Ionic. 2. In Vue 3.2 a [custom elements improvement shipped](https://github.com/vuejs/core/blob/main/changelogs/CHANGELOG-3.2.md#3238-2022-08-30) that changed how custom elements are referred to in VNodes. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The affected `watch` call now is now explicitly a deep watcher. This change is backwards compatible as well as forward compatible with upcoming Vue changes. - Updated IonTabs to account for the new VNode behavior for custom elements. Ionic still supports version of Vue that do not have this improvement, so we need to account for both behaviors for now. I also added a tech debt ticket to remove the old checks when we drop support for older versions of Vue. - Updated E2E test dependencies. During this update some of our tests needed to be updated to account for newer versions of Vue/Vitest. Overall I was able to simplify a lot of our tests as a result. I plan to add renovatebot to these E2E test apps, but I will handle that in a separate PR. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 4. Update the BREAKING.md file with the breaking change. 5. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.6-dev.11705526292.1bc0acb5` Note: Both of the issues cause tests to fail when using the latest dependencies in the Vue E2E test app. However, I need to use the latest dependencies so I can demonstrate that my changes do fix the reported issues. As a result, I have both fixes in the same PR.
Publishing GitHub releases for each nightly is creating more noise than the team would like. As a result, we are going to stop publishing the GitHub release. However, nightly builds will continue to automatically release. Developers can look at the commits in `main` to determine if a commit is in a nightly build: https://github.com/ionic-team/ionic-framework
Issue number: resolves #28455 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The main `ion-content` inside of a popover is not scrollable. Instead, the `.popover-viewport` container is scrolled because certain styles no longer applied once we moved popover to the Shadow DOM. This bug impacted the linked issue because it meant that the infinite scroll inside of the content never fires (since the content never scrolls). ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The `.popover-viewport` rule now targets slotted content with the`.popover-viewport` class. This class is added to the root node that is slotted. This enables us to target the user's content in the light dom. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.6.6-dev.11705696534.177666f8` --------- Co-authored-by: ionitron <hi@ionicframework.com>
…hen menu opens (#28829) Issue number: resolves #28399 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> As part of #26976 I fixed an issue where `pointer-events: none` was not applied until after the menu open gesture finishes. This resolved a bug where scrolling was latching after the menu gesture starts. However, I did not account for the edge case where scrolling latches _before_ `pointer-events: none` is applied in the DOM. Since scrolling has already latched then `pointer-events: none` does not change the scrolling behavior. This can happen if a user swipes up and to the right from the left edge of the screen. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - `overflow-y: hidden` is now applied to the scrollable content which will interrupt any scrolling when the menu is open. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Testing: This bug fixes a timing issue where scrolling latches on the main content as the menu tries to open. As a result, I am unable to write reliable automated tests for this. Reviewers should perform the following test on iOS and Android physical devices: 1. Open `src/components/menu/test/basic`. 2. Add enough elements to the main page content such that it scrolls (I added a list with items). 3. On each device, attempt to scroll the main content while also opening the menu on the starting edge of the screen. Scrolling on the main content should not happen if the menu opens. Dev build: `7.6.5-dev.11705341148.1a550d3b`
Release 7.6.6
…28865) Issue number: resolves #28344 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When an Accordion is inside an Accordion Group, and the Accordion Group is enabled and not readonly but the Accordion is disabled and/or readonly, it is possible to navigate to the accordion and open it using the keyboard. This should not be allowed, just like opening it on click is not allowed. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - A disabled Accordion inside an Accordion Group may not be opened via the keyboard. - A readonly Accordion inside an Accordion Group may not be opened via the keyboard. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
To make it easy for the team to quickly triage issues, we'd like to automatically assign issues to team members at random. This PR use https://github.com/marketplace/actions/auto-assign-issue to assign 1 member of the `framework` GitHub team to be the person to triage.
The token I was using didn't have the correct permissions, and I need to figure out how to generate a new token (I don't think I have access to the account where these tokens live). For now, I'm going to hard code the team members until I can figure out the token access out.
github-actions
bot
added
package: core
liamdebeasi
force-pushed
the
sync-8-1-25
branch
from
508c055 to
0fdd7d1
Compare
liamdebeasi
requested review from
a team,
averyjohnston,
brandyscarney,
sean-perkins and
thetaPC
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information