refactor(input): remove accept property #28946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
thetaPC
requested review from
a team,
liamdebeasi and
sean-perkins
as code owners
liamdebeasi
approved these changes
Feb 1, 2024
Contributor
There was a problem hiding this comment.
Change looks good. Don't forget to add a BREAKING CHANGE message to the bottom of the commit description when merging: https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#examples
Also, the commit should probably be refactor here instead of feat since we are removing a feature, not adding one.
liamdebeasi
changed the title
liamdebeasi
changed the title
liamdebeasi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ion-inputhas a deprecated property:accept. This property was marked deprecated because thefilevalue fortypeis not a valid value in Ionic Framework.What is the new behavior?
acceptproperty.Does this introduce a breaking change?
acceptcan only be used when the input has a type offile. However,fileis not a valid value in Ionic Framework so theacceptproperty was removed.Other information
Related PR