refactor(input): deprecate accept property #25501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25500
The
typeproperty has never accepted'file'as a valid value. However, our documentation makes references to'file'in themultipleandacceptproperties.Both descriptions were likely adapted from descriptions on MDN, which made reference to
'file'.Additionally, the
acceptproperty was added to have greater parity with the nativeinput: fe99d19 However, this was a mistake asion-inputnever supported'file'.What is the new behavior?
acceptpropertyacceptproperty to state that it is ignored. It technically works if you forcetypeto'file', but'file'is not a valid value. We could stop passingacceptinto the nativeinput, but that would be a breaking change.'file'reference from themultipleprop description.Does this introduce a breaking change?
Other information