feat(radio): add ionic theme styles #29805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
This is looking good, I mostly have questions on some of the implementation details. 🙂
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
brandyscarney
approved these changes
Aug 29, 2024
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Looks good, just a suggested change to simplify the mixin a bit. 🙂
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
BenOsodrac
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
ionictheme has not been implemented toion-radio.What is the new behavior?
ionictheme styles.ionicto the tests.Does this introduce a breaking change?
Other information
Preview (basic)
Preview (color)
Preview (item)
Preview (label placement)
Preview (states)