feat(button): add support for badge #30303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
requested changes
Mar 27, 2025
Comment on lines
314
to
327
| .button-native { | ||
| overflow: visible; | ||
|
|
||
| ion-ripple-effect { | ||
| // stylelint-disable-next-line property-disallowed-list | ||
| border-radius: inherit; | ||
| } | ||
|
|
||
| &::after { | ||
| // stylelint-disable-next-line property-disallowed-list | ||
| border-radius: inherit; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
After thinking it more, it would be best to revert it to what you had but some changes. Make sure to revert the snapshots as well.
Suggested change
| .button-native { | |
| overflow: visible; | |
| ion-ripple-effect { | |
| // stylelint-disable-next-line property-disallowed-list | |
| border-radius: inherit; | |
| } | |
| &::after { | |
| // stylelint-disable-next-line property-disallowed-list | |
| border-radius: inherit; | |
| } | |
| } | |
| .button-native { | |
| ion-ripple-effect { | |
| // stylelint-disable-next-line property-disallowed-list | |
| border-radius: inherit; | |
| } | |
| &::after { | |
| // stylelint-disable-next-line property-disallowed-list | |
| border-radius: inherit; | |
| } | |
| } | |
| // This rule works for Chrome. | |
| :has(ion-badge) .button-native, | |
| // This rule works for the rest of the browsers. | |
| :host(:has(ion-badge)) .button-native { | |
| --overflow: visible; | |
| } |
# Conflicts: # core/src/components/badge/badge.common.scss
thetaPC
requested changes
Mar 28, 2025
Comment on lines
+319
to
+325
| // This rule works for Chrome. | ||
| :has(ion-badge) .button-native { | ||
| --overflow: visible; | ||
| } | ||
|
|
||
| // This rule works for the rest of the browsers. | ||
| :host(:has(ion-badge)) .button-native { |
There was a problem hiding this comment.
Suggested change
| // This rule works for Chrome. | |
| :has(ion-badge) .button-native { | |
| --overflow: visible; | |
| } | |
| // This rule works for the rest of the browsers. | |
| :host(:has(ion-badge)) .button-native { | |
| // This rule works for Chrome. | |
| :has(ion-badge) .button-native, | |
| // This rule works for the rest of the browsers. | |
| :host(:has(ion-badge)) .button-native { |
BenOsodrac
requested changes
Mar 31, 2025
| // Badge in Button | ||
| // -------------------------------------------------- | ||
|
|
||
| :host(:not(:empty).in-button) { |
There was a problem hiding this comment.
This CSS should be moved to badge.native.scss, along with the vars to badge.native.vars.scss.
Then this css should be repeated on ionic.theme.scss but using the design tokens directly.
This way, wee keep the consistency with the scss architecture of other patterns, between design systems, and if in the future the tokens change values, we won't need to manually change this CSS for the Ionic Theme.
BenOsodrac
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The ion-badge is not currently supported when inside the ion-button.
What is the new behavior?
Does this introduce a breaking change?
Other information