-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(button): add support for badge #30303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
4b38f4a
feat(badge): Add context selector when inside tab button.
joselrio 2ea2c3a
feat(badge): Add styling when in context of tab button
joselrio 53e64e6
feat(tab-button): Adding styling to the badge.
joselrio 293d49c
feat(badge): Adding sample section when inside tab button.
joselrio 15d96fd
feat(badge): Adding visual tests when inside tab button.
joselrio 380c3df
fix(badge): Fixed html structure.
joselrio 82d587e
feat(badge): Adding screenshot tests to badge when inside tab button
joselrio 49e2e3b
fix(badge): run lint and fix based on lint feedback.
joselrio 715bb99
feat(badge): create new badge tokens when inside tab button
joselrio f4e4813
feat(badge): make usage of the new tokens when inside tab button
joselrio 35bca0a
feat(tab-button): new tokens to style badge when inside tab button
joselrio 08c9a58
feat(tab-button): make usage of the new tokens to style badge
joselrio a93fcc7
feat(badge): updated test screenshots when inside tab button.
joselrio 1061f8b
feat(badge): fix text vertical alignment when at md device.
joselrio 1608e3e
feat(badge): update screenshots when inside tab button
joselrio 1252527
fix(badge): Remove added styling under the context of tab button from…
joselrio 78b5905
fix(badge): run lint
joselrio 9a50f62
fix(badge): remove unneeded context.
joselrio 2cd81fd
feat(badge): update badge test when inside tab button
joselrio bff2834
Merge branch 'next' into ROU-11666
joselrio f7c2378
fix(badge): Update screenshot tests when inside tab button.
joselrio def8fb9
fix(badge): run lint
joselrio 85bfa52
fix(badge): improvements made based on feedback.
joselrio ac8f03f
fix(badge): updated tests screenshots.
joselrio 30a3dfa
feat(badge): fix empty badge style when inside tab button.
joselrio ffcade7
fix(badge): update test page.
joselrio 9e841b1
feat(badge): Updated tests screenshots.
joselrio d50c383
fet(badge): Update missing screenshot.
joselrio d8ff3ac
feat(badge): adding new tab button with badge use case.
joselrio ff966dd
feat(badge): Screenshot tests, update.
joselrio 4946f13
feat(tab-button): Style badge when tab button has icon at bottom.
joselrio 4a0b391
feat(badge): Update when inside tab button based on feedback.
joselrio 19671b7
Merge branch 'next' into ROU-11666
joselrio 3fa1864
fix(badge): remove unneeded variables file.
joselrio 2695132
fix(badge): Grouping hint tests.
joselrio 51af9f6
fix(tab-button): Make usage of token vars only and clean css vars.
joselrio d9ac8e9
fix(tab-button): remove scss variables.
joselrio 065bb26
fix(badge): Remove unneeded property.
joselrio 3e13b38
fix(badge): removed overriding size.
joselrio 5827770
fix(tab-button): removed overriding size.
joselrio 6346aa7
fix(tab-button): remove unneeded property.
joselrio 9a876f7
Merge branch 'next' into ROU-11666
joselrio 5954d03
feat(badge): run lint
joselrio 762efec
fix(badge): update tests screenshots.
joselrio 06ee460
fix(tab-button): update tests screenshots.
joselrio 512732a
feat(badge): remove badge empty size since it's unneeded.
joselrio a2666e2
feat(badge): Update tests and screenshots.
joselrio aa6cadc
feat(tab-button): remove existing dependency.
joselrio 5e0b248
feat(badge): code conventions
joselrio a143b8b
feat(badge): code conventions
joselrio 0863a0f
feat(badge): code conventions
joselrio 6867820
feat(badge): set default size
joselrio 1552104
Merge branch 'next' into ROU-11666
joselrio 823e9f1
fix(badge): text sentence
joselrio 32e9bdd
feat(badge): remove default values.
joselrio 3f805a0
feat(badge): update tests screenshots
joselrio 21a4e65
feat(tab-button): update tests screenshots.
joselrio d8dee22
fix(core): Delete vue utils.ts
joselrio b7cfd97
Merge branch 'refs/heads/next' into ROU-11612
OS-pedrolourenco ab9acac
Add support for badges in ion-button
OS-pedrolourenco ae4187c
CR
OS-pedrolourenco ea679a0
Update snapshots
OS-pedrolourenco 518a4de
CR
OS-pedrolourenco 3d7ec25
CR
OS-pedrolourenco 6837e3e
CR
OS-pedrolourenco bd8e625
Merge branch 'next' into ROU-11612
OS-pedrolourenco 379b77e
Merge branch 'next' into ROU-11612
OS-pedrolourenco 01d47c3
Fix broken tests
OS-pedrolourenco dc4ec1d
CR
OS-pedrolourenco 0f6400d
Merge branch 'next' into ROU-11612
OS-pedrolourenco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+4.52 KB
...s-snapshots/badge-hint-button-bottom-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.92 KB
...-snapshots/badge-hint-button-bottom-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.84 KB
...s-snapshots/badge-hint-button-bottom-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.75 KB
...badge.e2e.ts-snapshots/badge-hint-button-bottom-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.47 KB
...adge.e2e.ts-snapshots/badge-hint-button-bottom-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.26 KB
...badge.e2e.ts-snapshots/badge-hint-button-bottom-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.87 KB
.../badge.e2e.ts-snapshots/badge-hint-button-bottom-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.13 KB
...badge.e2e.ts-snapshots/badge-hint-button-bottom-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.92 KB
.../badge.e2e.ts-snapshots/badge-hint-button-bottom-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.73 KB
...e.ts-snapshots/badge-hint-button-top-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.96 KB
....ts-snapshots/badge-hint-button-top-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.94 KB
...e.ts-snapshots/badge-hint-button-top-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.04 KB
...nt/badge.e2e.ts-snapshots/badge-hint-button-top-ios-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.04 KB
...t/badge.e2e.ts-snapshots/badge-hint-button-top-ios-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.51 KB
...nt/badge.e2e.ts-snapshots/badge-hint-button-top-ios-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.96 KB
...int/badge.e2e.ts-snapshots/badge-hint-button-top-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.92 KB
...nt/badge.e2e.ts-snapshots/badge-hint-button-top-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.66 KB
...int/badge.e2e.ts-snapshots/badge-hint-button-top-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
...button.e2e.ts-snapshots/button-diff-ionic-ios-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+31 Bytes
(100%)
...button.e2e.ts-snapshots/button-diff-ionic-ios-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+272 Bytes
(100%)
.../test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.06 KB
(98%)
...on.e2e.ts-snapshots/button-outline-ionic-ios-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+287 Bytes
(100%)
...ton.e2e.ts-snapshots/button-outline-ionic-ios-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.87 KB
(98%)
...on.e2e.ts-snapshots/button-outline-ionic-ios-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+523 Bytes
(100%)
...ton.e2e.ts-snapshots/button-outline-ionic-ios-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.02 KB
(100%)
.../outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.3 KB
(100%)
...outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.5 KB
(100%)
.../outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.04 KB
(100%)
.../outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.7 KB
(100%)
...outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1.66 KB
(100%)
.../outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+51 Bytes
(100%)
...e2e.ts-snapshots/button-activated-outline-color-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+87 Bytes
(110%)
...2e.ts-snapshots/button-activated-outline-color-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+60 Bytes
(100%)
...e2e.ts-snapshots/button-activated-outline-color-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+51 Bytes
(100%)
...utton.e2e.ts-snapshots/button-activated-outline-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+105 Bytes
(110%)
...tton.e2e.ts-snapshots/button-activated-outline-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+72 Bytes
(100%)
...utton.e2e.ts-snapshots/button-activated-outline-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
...n.e2e.ts-snapshots/button-activated-solid-color-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+7 Bytes
(100%)
.../button.e2e.ts-snapshots/button-activated-solid-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
.../button.e2e.ts-snapshots/button-activated-solid-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+57 Bytes
(100%)
...2e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-ltr-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+778 Bytes
(100%)
...e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-ltr-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+55 Bytes
(100%)
...2e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-ltr-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+105 Bytes
(100%)
...-snapshots/toolbar-basic-text-icon-buttons-ios-ltr-dark-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+65 Bytes
(100%)
...snapshots/toolbar-basic-text-icon-buttons-ios-ltr-dark-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+65 Bytes
(100%)
...-snapshots/toolbar-basic-text-icon-buttons-ios-ltr-dark-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+45 Bytes
(100%)
...2e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-rtl-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+669 Bytes
(100%)
...e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-rtl-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+200 Bytes
(100%)
...2e.ts-snapshots/toolbar-basic-text-icon-buttons-ios-rtl-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
+84 Bytes
(100%)
...-snapshots/toolbar-basic-text-icon-buttons-ios-rtl-dark-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+53 Bytes
(100%)
...snapshots/toolbar-basic-text-icon-buttons-ios-rtl-dark-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+65 Bytes
(100%)
...-snapshots/toolbar-basic-text-icon-buttons-ios-rtl-dark-Mobile-Safari-linux.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.