Conversation
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? `generate_dir_index` in `core/scripts/vercel-build.sh` writes child links like `<a href="basic/">` and an up-link `<a href="../">`. Vercel doesn't 308-redirect to add a trailing slash, so visiting a preview directory URL like `/src/components/progress-bar/test` (no slash) returns the index page but the browser resolves `basic/` against the parent directory. That path doesn't exist, and Vercel's fallback serves the root landing page, so navigation looks like it "circles back" to the preview home instead of opening the test scenario. ## What is the new behavior? The dir-index generator now emits absolute hrefs based on the directory's `url_path`, including the `../` up-link. Trailing-slash quirks no longer affect navigation between component test scenarios on Vercel previews. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information Test page: - https://ionic-framework-git-fix-vercel-preview-links-ionic1.vercel.app/src/components/progress-bar/test Versus the broken version on main: - https://ionic-framework-git-main-ionic1.vercel.app/src/components/progress-bar/test
…class on initial entry (#31108) Issue number: internal --------- ## What is the current behavior? `ion-datetime` runs two IntersectionObservers: one to detect when the host becomes visible (which adds `datetime-ready`) and one to detect when it becomes hidden (which removes the class and tears down listeners). When the host mounts offscreen, both observers receive an initial "not intersecting" entry on `observe()`. The hidden-state observer treats that initial entry as a real visible-to-hidden transition, queues a `writeTask` to remove `datetime-ready`, and races the layout-based fallback (`ensureReadyIfVisible`) that adds the class after 100ms. On WebKit the remove wins often enough that the e2e test for the fallback (added in #30793 to fix #30706) had to be skipped on Mobile Safari. Anything in production that adds `datetime-ready` outside of a real `isIntersecting: true` event is exposed to the same race. ## What is the new behavior? A `hasBeenIntersecting` flag is set true only when `visibleCallback` observes `isIntersecting: true`. The hidden-state observer's teardown is gated on this flag, so the synthetic initial "not intersecting" entry is ignored. The flag is reset when the host actually transitions to hidden and on `disconnectedCallback`. The previously duplicated init-listeners + ready-class block is consolidated into a single `markReady` helper. The WebKit skip on the IO-fallback e2e test has been removed. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If yes, please describe the impact and migration path for existing applications below. --> ## Other information The asymmetry where `ensureReadyIfVisible` (the layout fallback) deliberately does NOT set `hasBeenIntersecting` is load-bearing: the flag must reflect a real observer signal, not a fallback-driven write, otherwise the bug returns. This is called out at the guard site so future cleanups don't undo it. This test was most likely to fail in docker testing Linux Webkit with `--repeat-each=20` because it was pretty flaky. I was able to force it to fail under these conditions and, after fixing it, it no longer failed. ## Relevant Preview Link: - https://ionic-framework-git-fw-7284-ionic1.vercel.app/src/components/datetime/test/basic
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pozil/auto-assign-issue](https://redirect.github.com/pozil/auto-assign-issue) | action | major | `v2.2.0` → `v3.0.0` | --- ### Release Notes <details> <summary>pozil/auto-assign-issue (pozil/auto-assign-issue)</summary> ### [`v3.0.0`](https://redirect.github.com/pozil/auto-assign-issue/releases/tag/v3.0.0): - Switch to EcmaScript Module [Compare Source](https://redirect.github.com/pozil/auto-assign-issue/compare/v2.2.0...v3.0.0) - feat: switch to EcmaScript Module - build: bump dependencies </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "every weekday before 11am" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMzkuNyIsInVwZGF0ZWRJblZlciI6IjQzLjEzOS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…uttons (#31109) Issue number: resolves #31090 --------- ## What is the current behavior? Buttons configured with `role: "selected"` no longer receive the `action-sheet-selected` CSS class. Userland styling that targets `.action-sheet-selected` (the documented hook for marking the active option — bold text, custom checkmarks, etc.) silently stopped working as of `8.7.12`. This regressed in #30769 (`fix(select, action-sheet): use radio role for options`). The new render path computes the button's class as: ```tsx class={{ ...buttonClass(b), 'action-sheet-selected': isActiveRadio, }} ``` `buttonClass(b)` already emits `'action-sheet-selected': true` for `role: "selected"` (via `[action-sheet-${button.role}]]: button.role !== undefined`), but the second key with the same name overrides it. For any non-radio button `isActiveRadio` is `false`, so the class is dropped from the rendered `<button>`. ### Repro ```html <ion-action-sheet id="sheet" header="Choose"></ion-action-sheet> <script type="module"> await customElements.whenDefined("ion-action-sheet"); const sheet = document.getElementById("sheet"); sheet.buttons = [ { text: "Option A" }, { text: "Option B", role: "selected" }, { text: "Cancel", role: "cancel" }, ]; await sheet.present(); </script> ``` In `8.7.11` the Option B button gets `action-sheet-selected`. In `8.7.12+` it does not. ## What is the new behavior? - Only override `action-sheet-selected` based on `isActiveRadio` when the button actually participates in the radio group (`b.htmlAttributes?.role === 'radio'`). For non-radio buttons, the class map produced by `buttonClass(b)` is left untouched, so `role: "selected"` keeps emitting `action-sheet-selected` exactly as it has since the component was introduced. - Adds a spec-test regression covering the `role: "selected"` case. This preserves the new radio-group behavior introduced in #30769 (when the button is a radio, `action-sheet-selected` follows `activeRadioId`) and restores the documented public API. ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information - The minified output for the lazy + custom-elements bundles becomes `Object.assign(Object.assign({}, buttonClass(b)), isRadio && {"action-sheet-selected": isActiveRadio})`. When `isRadio` is `false`, `Object.assign(target, false)` is a no-op and the class set by `buttonClass(b)` is preserved. - Verified in a real consumer app on 8.8.4: with this patch built and installed locally, `role: "selected"` once again renders `class="... action-sheet-selected ..."` on the `<button>`. Made with [Cursor](https://cursor.com)
…31112) Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? - When the first segment is disabled and the last item is selected, if the user swipes the `segment-view`, the first `segment-button` gets checked even if it is disabled, and the view is presenting other `segment-view`. ## What is the new behavior? - A validation was added to ensure that the `segment-button` can only be checked if it is not disabled ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
v8.8.6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync next with main.