Skip to content

chore(ci): add lint and check diff steps to angular-server build - #31322

Merged
ShaneK merged 2 commits into
major-9.0from
FW-7657
Aug 5, 2026
Merged

chore(ci): add lint and check diff steps to angular-server build#31322
ShaneK merged 2 commits into
major-9.0from
FW-7657

Conversation

@ShaneK

@ShaneK ShaneK commented Aug 3, 2026

Copy link
Copy Markdown
Member

Issue number: internal


What is the current behavior?

Currently, build-angular-server is the only framework build action with no lint step.

What is the new behavior?

The action now runs npm run lint after Sync and before Build, then reverts core/package.json and runs git diff --exit-code after Build, just like build-angular.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Had to fix one lint issue, too

@ShaneK
ShaneK requested a review from a team as a code owner August 3, 2026 22:03
@ShaneK
ShaneK requested a review from OS-jacobbell August 3, 2026 22:03
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview Aug 4, 2026 6:53pm

Request Review

@thetaPC thetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run: npm run build.prod
shell: bash
working-directory: ./packages/angular-server
- name: Clean core package.json

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No emoji?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShaneK
ShaneK merged commit 0622f83 into major-9.0 Aug 5, 2026
53 checks passed
@ShaneK
ShaneK deleted the FW-7657 branch August 5, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants