Skip to content

fix(range): update knob positions when dualKnobs changes - #31365

Merged
brandyscarney merged 3 commits into
mainfrom
FW-7143
Aug 18, 2026
Merged

fix(range): update knob positions when dualKnobs changes#31365
brandyscarney merged 3 commits into
mainfrom
FW-7143

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Aug 18, 2026

Copy link
Copy Markdown
Member

Issue number: resolves #31026


What is the current behavior?

Opening an ion-range with dualKnobs set to true with a value set inside of a modal does not render the values properly.

What is the new behavior?

  • Added a watcher for dualKnobs that calls updateRatio(), ensuring knob ratios are recomputed whenever dualKnobs changes. The min, max, and value properties already had watchers. dualKnobs was the only ratio-affecting property without one.
  • Knobs are now positioned correctly regardless of whether value or dualKnobs is assigned first. They are also repositioned correctly when dualKnobs is toggled at runtime in either direction.
  • Range now sets the correct values when used inside a modal, including when dualKnobs and value are assigned in different orders.
  • Improved the dualKnobs property description.
  • Added e2e tests covering both property assignment orders and runtime toggling of dualKnobs.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview Aug 18, 2026 8:55pm

Request Review

@github-actions github-actions Bot added the package: core @ionic/core package label Aug 18, 2026
@brandyscarney
brandyscarney marked this pull request as ready for review August 18, 2026 21:02
@brandyscarney
brandyscarney requested a review from a team as a code owner August 18, 2026 21:02

@thetaPC thetaPC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney
brandyscarney merged commit 7d64d62 into main Aug 18, 2026
64 checks passed
@brandyscarney
brandyscarney deleted the FW-7143 branch August 18, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-range: value attribute doesn't render correctly in a modal

2 participants