feat(): set platform mode on overlay components - #12167
Closed
Manduro wants to merge 40 commits into
Closed
Conversation
fixes ionic-team#9699 fixes ionic-team#11484 fixes ionic-team#11389 fixes ionic-team#11325 fixes ionic-team#11291 fixes ionic-team#10828 fixes ionic-team#11291 fixes ionic-team#10393 fixes ionic-team#10257 fixes ionic-team#9434 fixes ionic-team#8933 fixes ionic-team#7178 fixes ionic-team#7047 fixes ionic-team#10552 fixes ionic-team#10393 fixes ionic-team#10183 fixes ionic-team#10187 fixes ionic-team#10852 fixes ionic-team#11578
When `Tabs` are nested within each other, the highlight can get misaligned. This prevents that by ensuring the affected `.tab-highlight` is a direct child of the targeted `Tabs`.
…tabs * wip * wip * progress * wippy skippy * getting there * all tests passing except goBack * unit tests pass again boi * goBack tests pass * great success * the good stuff
…rds compatibility
Add option to set the platform mode when creating an overlay component. Alert already allows this. Now supports Action Sheet, Loading, Picker, Popover and Toast.
Collaborator
|
Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Add option to set the platform mode when creating an overlay component. This allows you to use an iOS style Action Sheet in an MD mode app, for example.
It works like passing a mode as input to a component, but with overlay components you pass it as an option to the controller. Alert already allows this in the same way. Now supports Action Sheet, Loading, Picker, Popover and Toast.
Changes proposed in this pull request:
Possible future work
It might be nice to abstract some of the overlay components logic away in a super class, like the
Ionclass does for normal components. This ensures more consistency in the future.Ionic Version: 3.x
Related issues
#10200