Update configs to new conventions from rsl_rl >= 5.0#5551
Conversation
Greptile SummaryThis PR migrates all RSL-RL agent PPO configs from the deprecated
Confidence Score: 5/5Safe to merge — this is a uniform config-only migration with no changes to environment logic, model architectures, or training algorithms. Every changed file is a configuration dataclass or documentation snippet. The mapping from old to new fields is verified end-to-end by the existing handle_deprecated_rsl_rl_cfg utility and its test suite. Normalization flags, hidden dims, distribution types (Gaussian vs. HeteroscedasticGaussian), and obs_groups keys are all faithfully preserved. Flat subclass overrides and the asymmetric ShadowHandAsymFF architecture are correctly migrated. No files require special attention. The gear-assembly RNN configs are the most complex (RslRlRNNModelCfg + HeteroscedasticGaussianDistributionCfg) but are correctly migrated. Important Files Changed
Reviews (1): Last reviewed commit: "Ruff" | Re-trigger Greptile |
|
Hi @StafaH, thanks a lot for the PR! The only problem I am seeing (and why I did not update the configs) is that there is a function that updates old configs to the new structure but not the other way around because it is already quite lengthy. Updating the configs would thus break the tasks if the user uses an older rsl-rl version. The options I am seeing are 1. also including logic for converting new configs to the old structure, 2. not updating the configs, or 3. accepting that the default tasks break for older rsl-rl versions. Cheers, |
|
Hi @ClemensSchwarke, I synced with @kellyguo11 and we prefer option 3. The develop branch pins rsl_rl >= 5.0 so we can begin migrating users to this with a warning or an error if we detect < 5.0 in the train script. I can also flip the old script to create the old config from the new config if an older version of rsl_rl is detected, inverting the whole setup (isaaclab 3.0 will use new configs and rsl_rl >= 5.0. Not sure if this needed but if you recommend then we can do that. |
|
I agree for lab 3.0, I missed that this PR isn't going to main. Thanks @StafaH ! |
Description
Formatted articulation root predicate expressions for readability. No behavior change and no new dependencies.
Type of change
Code cleanup and migration to rsl_rl >= 5.0
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there