Add support for python-env.sh for dev workflows#6434
Merged
pbarejko merged 1 commit intoJul 9, 2026
Conversation
Contributor
Comment on lines
+52
to
+56
| if [ -n "$VIRTUAL_ENV" ] || [ -n "$CONDA_PREFIX" ]; then | ||
| env_site_packages="$("$python_exe" -c 'import site; print(site.getsitepackages()[0])' 2>/dev/null || true)" | ||
| if [ -n "$env_site_packages" ]; then | ||
| export PYTHONPATH="$env_site_packages:$PYTHONPATH" | ||
| fi |
Contributor
There was a problem hiding this comment.
env_isaaclab venv not covered by site-packages fix
The guard [ -n "$VIRTUAL_ENV" ] || [ -n "$CONDA_PREFIX" ] excludes the third resolution path for python_exe (line 19): the auto-discovered env_isaaclab venv. When a user has env_isaaclab present but no explicitly activated venv/conda, python_exe already points at env_isaaclab/bin/python, yet the site-packages prepend is never performed. After setup_python_env.sh injects Kit's prebundle directories into PYTHONPATH, those vendored copies will still shadow env_isaaclab's packages — the exact problem this block is meant to prevent.
huidongc
approved these changes
Jul 9, 2026
maxkra15
pushed a commit
to maxkra15/IsaacLab
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Local Isaac Sim builds (6.1+) ship setup_python_env.sh instead of setup_conda_env.sh. Isaac Lab only sourced the latter, breaking the developer workflow when _isaac_sim points at a source build. This PR falls back to setup_python_env.sh, sets the required Kit env vars, and prepends the active environment's site-packages to avoid Kit prebundle shadowing.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there