Skip to content

Update documentation for 03_ik_controller.rst#7

Merged
Mayankm96 merged 1 commit intoisaac-sim:mainfrom
kouroshD:kouroshD-patch-1
Jan 25, 2023
Merged

Update documentation for 03_ik_controller.rst#7
Mayankm96 merged 1 commit intoisaac-sim:mainfrom
kouroshD:kouroshD-patch-1

Conversation

@kouroshD
Copy link
Copy Markdown
Contributor

@kouroshD kouroshD commented Jan 24, 2023

Description

Fixes the documentation issue based on the https://github.com/NVIDIA-Omniverse/Orbit/blob/e05a357a5974c29cdff86c2d77bfb46cc17bbc05/source/standalone/demo/play_ik_control.py#L24

Type of change

  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with pre-commit run --all-files (see here instructions to set it up)
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file

@Mayankm96 Mayankm96 self-requested a review January 25, 2023 00:19
Copy link
Copy Markdown
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for pointing this out.

@Mayankm96 Mayankm96 merged commit 4f68019 into isaac-sim:main Jan 25, 2023
@Mayankm96 Mayankm96 added the documentation Improvements or additions to documentation label Jan 26, 2023
junhyekh added a commit to junhyekh/IsaacLab that referenced this pull request Nov 18, 2024
renezurbruegg added a commit to renezurbruegg/IsaacLab that referenced this pull request Feb 8, 2026
# Description

This PR introduces an actuator model that takes care of the Serial to
Parallel conversion for the dynaarm,

(Part of the dynaarm integration isaac-sim#6)

## Type of change

- New feature (non-breaking change which adds functionality)

## Screenshots
## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

---------

Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Co-authored-by: Mayank Mittal <mittalma@leggedrobotics.com>
renezurbruegg added a commit to renezurbruegg/IsaacLab that referenced this pull request Feb 8, 2026
# Description

Adds the dynaarm asset with and without covers and the correct collision
shapes.

It depends on the Parallel Actuator model from isaac-sim#7 

To view an example: 
```python
 ./isaaclab.sh -p source/standalone/demos/dynaarms.py
 ```
![image](https://github.com/user-attachments/assets/607e16fe-088d-41ae-a2ef-3c5f251095c3)

(This PR is part of isaac-sim#6)

## Type of change
- New feature (non-breaking change which adds functionality)

## Screenshots


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there

---------

Co-authored-by: Pascal <roth.pascal@outlook.de>
renezurbruegg added a commit to renezurbruegg/IsaacLab that referenced this pull request Feb 8, 2026
# Description

```bash
./isaaclab.sh -p source/standalone/environments/random_agent.py --task Isaac-Sysid-Dynaarm-v0 --num_envs 2
./isaaclab.sh -p source/standalone/environments/random_agent.py --task Isaac-Sysid-Dynaarm-Covers-v0 --num_envs 2
```

This PR adds the sysid environments for the dynaarm.

Sysid environments are environments which only contain the standalone
assets and directly observe joint positions and velocities.

This PR depends on isaac-sim#7 and isaac-sim#8, which need to be merged first.

Related Issue: isaac-sim#6 
## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Screenshots

Please attach before and after screenshots of the change if applicable.

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Co-authored-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Co-authored-by: Pascal <roth.pascal@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants