[Validation] Test OVRTX 0.4.1 with OVPhysX 0.5.10 - #7143
Conversation
OvPhysX 0.5.10 requires ovstage 0.1.1.355824, so the two move together: bumping ovphysx alone leaves the environment unresolvable. The code change this depends on is already on develop. OvPhysX reads sealed data only, so attaching at an unsealed ordinal silently yields an empty scene, which surfaced as a null joint-friction buffer during articulation setup. `advance_write_floor` in the OvPhysX manager commits the ordinal first. Verified locally on a clean environment: Isaac-Velocity-Flat-AnymalD with physics=ovphysx trains, which is the articulation path that failed before the fix. That is a smoke test rather than a soak.
Use the public OVRTX release, enable synchronous texture streaming, and retire rendering exemptions fixed by the updated runtime.
Remove obsolete compatibility paths and align renderer configuration, license handling, and documentation with the required runtime.
Keep release validation on the exact public OVRTX build instead of admitting unverified 0.4.x updates.
There was a problem hiding this comment.
Isaac Lab Review Bot
The OV runtime pin updates, public-PyPI routing, renderer configuration changes, particle-path cleanup, documentation, lock file, and license alias handling are internally consistent. One CI change should be corrected before merge: the OVStage rendering job is now enabled for every pull request rather than remaining post-merge-only validation.
- Design and architecture: The exact OVRTX pin supports passing the 0.4.1 renderer options directly and removing the older compatibility workaround. The material concern is CI architecture: enabling another 120-minute self-hosted GPU rendering matrix for all pull requests creates a permanent repository-wide validation cost for what the comment describes as validation-branch coverage.
- API: The OV runtime versions are consistently mirrored across the version table, extras, package metadata, lock file, installation documentation, error guidance, and version-consistency tests. No public API compatibility issue was identified.
- Implementation: The renderer construction and particle update paths, rendering test changes, golden-image integration, and license-check alias logic were traced without another actionable issue. Restore or appropriately scope the OVStage workflow condition so this temporary pin-validation job does not run its PR matrix on every future pull request.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| if: >- | ||
| github.event_name != 'pull_request' && | ||
| needs.build.result == 'success' | ||
| if: needs.build.result == 'success' |
There was a problem hiding this comment.
🟡 Warning · Implementation — OVStage rendering job now runs on every PR
The removed github.event_name != 'pull_request' guard kept this 120-minute self-hosted GPU job post-merge only, and the added comment labels it a "Validation branch" change to exercise the new pins. As written, every pull request permanently gains a second full kitless rendering matrix, and the test-node-ids-file/test-node-ids-key inputs still apply only on push, so PR runs execute the uncurated matrix. Restore the post-merge condition before merging.
There was a problem hiding this comment.
this is the intention - test pr
Greptile SummaryThis PR updates the coordinated OVRTX, OvPhysX, and OVStage runtime pins and adjusts renderer behavior and rendering validation for the new releases.
Confidence Score: 5/5The PR appears safe to merge because no concrete blocking or independently actionable non-blocking defect was established. The dependency pins, renderer configuration, documentation, lock data, and rendering validation changes are internally coordinated, and the investigated installation, particle-update, and workflow-exposure concerns lacked a reachable demonstrated failure. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Pins[pyproject runtime pins] --> Lock[uv.lock]
Lock --> Runtime[OVRTX / OvPhysX / OVStage runtime]
Runtime --> Renderer[OVRTXRenderer configuration]
Renderer --> Outputs[Rendered camera outputs]
Outputs --> Golden[Golden-image validation]
Golden --> CI[OVStage pull-request CI job]
Reviews (1): Last reviewed commit: "style: Align OVStage validation comment" | Re-trigger Greptile |
## Summary - Updates OvPhysX to `0.5.10` and OVStage to `0.1.1.355824` while retaining OVRTX `0.4.1.364340`. - Adds the OVStage proprietary-license alias and regenerates `uv.lock`. - Supersedes #7140; thanks to @AntoineRichard for the original dependency work. #7143 remains validation-only evidence and will not be merged. ## Validation - Resolved and imported the exact OvPhysX, OVStage, and OVRTX versions. - Focused dependency, renderer, runtime, and OvPhysX environment tests: 105 passed. - Six-file legacy rendering sweep: 36 passed, 36 intentional unsupported-preset skips, no retries, and no golden changes. - Focused OVStage rendering sweep: 36 passed, 36 intentional skips, no retries, and no golden changes. - Lockfile, changelog, pre-commit, and diff checks passed. ## Type of change - Dependency update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Validation-only PR; do not merge.
Combines #7108 with the dependency pins from #7140 and temporarily enables the OVStage kitless pull-request lane.
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there