Update OvPhysX to 0.5.10 - #7150
Conversation
Pin the matching OVStage build while preserving the validated OVRTX 0.4.1 runtime.
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed the coordinated OvPhysX 0.5.10 and OVStage 0.1.1.355824 dependency update across root extras, package metadata, lockfile, validation, changelog, and license exception metadata; OVRTX remains exactly pinned at 0.4.1.364340.
- Design and architecture: The coupled OvPhysX/OVStage versions are consistently mirrored from the root version table into all three OV extras and the isaaclab_ov dependency. No new dependency path or resolution fork is introduced, and the OVStage license alias follows the existing exception structure.
- API: No public Python or CLI API changes are introduced. The externally visible dependency contract changes consistently for the ov, ovphysx, and ovrtx extras and for isaaclab_ov, with migration guidance provided in the isaaclab_ov changelog fragment.
- Implementation: The single-source version assertion, extra pins, isaaclab_ov requirement, and resolved ovphysx/ovstage wheel entries agree. The regenerated lockfile also refreshes versions of several editable in-repository packages; these appear to be generated metadata rather than dependency behavior changes, but are the main non-blocking review tradeoff.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryThe PR updates OvPhysX to 0.5.10 and its matching OVStage build while retaining the existing exact OVRTX pin.
Confidence Score: 5/5The PR appears safe to merge with the dependency pins, package metadata, lockfile, test assertion, and license exception aligned. The upgraded OvPhysX and OVStage versions are consistently represented across installation extras, package metadata, and locked artifacts, and no changed vulnerable dependency or manifest-to-lock mismatch remains. Important Files Changed
Reviews (1): Last reviewed commit: "chore: Update OvPhysX to 0.5.10" | Re-trigger Greptile |
Summary
0.5.10and OVStage to0.1.1.355824while retaining OVRTX0.4.1.364340.uv.lock.Validation
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there