Skip to content

Update OvPhysX to 0.5.10 - #7150

Merged
nvsekkin merged 1 commit into
isaac-sim:developfrom
nvsekkin:esekkin/ovphysx-0510
Aug 18, 2026
Merged

Update OvPhysX to 0.5.10#7150
nvsekkin merged 1 commit into
isaac-sim:developfrom
nvsekkin:esekkin/ovphysx-0510

Conversation

@nvsekkin

@nvsekkin nvsekkin commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Validation

  • Resolved and imported the exact OvPhysX, OVStage, and OVRTX versions.
  • Focused dependency, renderer, runtime, and OvPhysX environment tests: 105 passed.
  • Six-file legacy rendering sweep: 36 passed, 36 intentional unsupported-preset skips, no retries, and no golden changes.
  • Focused OVStage rendering sweep: 36 passed, 36 intentional skips, no retries, and no golden changes.
  • Lockfile, changelog, pre-commit, and diff checks passed.

Type of change

  • Dependency update

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Pin the matching OVStage build while preserving the validated OVRTX 0.4.1 runtime.

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

Reviewed the coordinated OvPhysX 0.5.10 and OVStage 0.1.1.355824 dependency update across root extras, package metadata, lockfile, validation, changelog, and license exception metadata; OVRTX remains exactly pinned at 0.4.1.364340.

  • Design and architecture: The coupled OvPhysX/OVStage versions are consistently mirrored from the root version table into all three OV extras and the isaaclab_ov dependency. No new dependency path or resolution fork is introduced, and the OVStage license alias follows the existing exception structure.
  • API: No public Python or CLI API changes are introduced. The externally visible dependency contract changes consistently for the ov, ovphysx, and ovrtx extras and for isaaclab_ov, with migration guidance provided in the isaaclab_ov changelog fragment.
  • Implementation: The single-source version assertion, extra pins, isaaclab_ov requirement, and resolved ovphysx/ovstage wheel entries agree. The regenerated lockfile also refreshes versions of several editable in-repository packages; these appear to be generated metadata rather than dependency behavior changes, but are the main non-blocking review tradeoff.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates OvPhysX to 0.5.10 and its matching OVStage build while retaining the existing exact OVRTX pin.

  • Updates the Omniverse extras, shared version table, package metadata, and lockfile consistently.
  • Adds the proprietary-license alias reported by the new OVStage package.
  • Updates dependency assertions and changelog fragments for the supported runtime pair.

Confidence Score: 5/5

The PR appears safe to merge with the dependency pins, package metadata, lockfile, test assertion, and license exception aligned.

The upgraded OvPhysX and OVStage versions are consistently represented across installation extras, package metadata, and locked artifacts, and no changed vulnerable dependency or manifest-to-lock mismatch remains.

Important Files Changed

Filename Overview
pyproject.toml Updates all Omniverse optional extras and centralized version pins to the intended OvPhysX, OVStage, and OVRTX combination.
source/isaaclab_ov/pyproject.toml Aligns the isaaclab-ov package dependency with the required OVStage build.
uv.lock Resolves the new exact OvPhysX and OVStage wheels while preserving OVRTX and synchronizing editable package versions with their manifests.
.github/workflows/license-exceptions.json Adds the SPDX-style proprietary-license alias emitted by the updated OVStage metadata.
source/isaaclab/test/cli/test_uv_run_pyproject.py Updates the single-source dependency-pin assertion for OvPhysX 0.5.10.

Reviews (1): Last reviewed commit: "chore: Update OvPhysX to 0.5.10" | Re-trigger Greptile

@nvsekkin
nvsekkin merged commit 382b924 into isaac-sim:develop Aug 18, 2026
77 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants