Skip to content

Conversation

@hrodward
Copy link
Contributor

Grammar suggestions

Grammar suggestions
@iliakan
Copy link
Member

iliakan commented Oct 25, 2019

Maybe "That can lead to interesting consequences when the prototype property is changed after the object is created." ?

@iliakan iliakan requested a review from paroche October 25, 2019 11:17
@hrodward
Copy link
Contributor Author

Yep, 'the' is better

@paroche
Copy link
Collaborator

paroche commented Oct 25, 2019

Agreed. "the prototype property". There's only one (for a given class).

@paroche
Copy link
Collaborator

paroche commented Oct 25, 2019

However, in the same patch:

2. Most classes do not have Symbol.hasInstance. In that case, the standard logic is used: obj instanceOf Class checks whether Class.prototype equals to one of prototypes in the obj prototype chain.
2. Most classes do not have Symbol.hasInstance. In that case, the standard logic is used: obj instanceOf Class checks whether Class.prototype equals to any prototype in the obj prototype chain."

Both are wrong. It should be "is equal to any prototype", "is equal to one of the prototypes", "equals any prototype", or "equals one of the prototypes". Never "equals to". I would somewhat favor the one I put in bold.

@iliakan
Copy link
Member

iliakan commented Oct 26, 2019

@hrodward will you update the patch if the suggestion is acceptable?

Updated based on comments
@hrodward
Copy link
Contributor Author

@hrodward will you update the patch if the suggestion is acceptable?

Done!

@lex111 lex111 merged commit df58d3f into javascript-tutorial:master Oct 30, 2019
@lex111
Copy link
Member

lex111 commented Oct 30, 2019

@hrodward thanks!

@hrodward hrodward deleted the patch-31 branch October 30, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants