Skip to content

Comments

1-js/05-data-types/04-array/#145

Merged
javascript-translate-bot merged 50 commits intojavascript-tutorial:masterfrom
ValeriiGri:master
May 20, 2019
Merged

1-js/05-data-types/04-array/#145
javascript-translate-bot merged 50 commits intojavascript-tutorial:masterfrom
ValeriiGri:master

Conversation

@ValeriiGri
Copy link
Contributor

@ValeriiGri ValeriiGri commented May 5, 2019

Article + tasks

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 5, 2019
@CLAassistant
Copy link

CLAassistant commented May 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ValeriiGri ValeriiGri changed the title Arrays 1-js/05-data-types/04-array/ May 6, 2019
lex111
lex111 requested changes May 6, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Весьма неплохой перевод, первые предложения для его улучшения.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 6, 2019
@ValeriiGri
Copy link
Contributor Author

ValeriiGri commented May 6, 2019

через Commit suggestion исправить ?

@lex111
Copy link
Member

lex111 commented May 6, 2019

@ValeriiGri как вам удобно, я оформил как предложения, чтобы эти изменения можно быстро и легко применить.

lex111 and others added 8 commits May 6, 2019 17:39
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/article.md
29cfab3 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/article.md
d3aae6a 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/article.md
4360722 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/article.md
aed7055 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/article.md
0ae9e31 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/3-call-array-this/task.md
0a55076 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/2-create-array/task.md
8a80894 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@lex111 @ValeriiGri
Update 1-js/05-data-types/04-array/10-maximal-subarray/task.md
751fbc3 
Co-Authored-By: ValeriiGri <valeragg65@gmail.com>
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 14, 2019
iliakan
iliakan requested changes May 14, 2019
View reviewed changes
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внеси, пожалуйста, правки. Спасибо!

@javascript-translate-bot
Copy link
Contributor

javascript-translate-bot commented May 14, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label May 14, 2019
@ValeriiGri
Copy link
Contributor Author

ValeriiGri commented May 17, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 17, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team May 17, 2019 07:41
iliakan
iliakan requested changes May 19, 2019
View reviewed changes
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Минификс

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 19, 2019
@javascript-translate-bot
Copy link
Contributor

javascript-translate-bot commented May 19, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ValeriiGri
Copy link
Contributor Author

ValeriiGri commented May 20, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 20, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team May 20, 2019 07:21
@iliakan
Copy link
Member

iliakan commented May 20, 2019

🚀

@javascript-translate-bot javascript-translate-bot merged commit 0ac48e5 into javascript-tutorial:master May 20, 2019
@iliakan iliakan mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iliakan iliakan iliakan requested changes

@lex111 lex111 lex111 approved these changes

Assignees

No one assigned

Labels

needs +1 One more review needed review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ValeriiGri @CLAassistant @lex111 @javascript-translate-bot @iliakan