Skip to content

Comments

1-js/13-modules/02-import-export/article.md#164

Merged
javascript-translate-bot merged 3 commits intojavascript-tutorial:masterfrom
ca11ado:export-import2
May 20, 2019
Merged

1-js/13-modules/02-import-export/article.md#164
javascript-translate-bot merged 3 commits intojavascript-tutorial:masterfrom
ca11ado:export-import2

Conversation

@ca11ado
Copy link
Contributor

@ca11ado ca11ado commented May 9, 2019

Перевод статьи: "Экспорт и импорт". Обновленный Pull Request (старый тут #135)

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 9, 2019
@ca11ado
Copy link
Contributor Author

ca11ado commented May 11, 2019

Чтобы быть уверенным: @iliakan я переоткрыл этот PR по твоей просьбе, а прошлый (#135) закрыл.

В #60 в списке пока указан старый.

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels May 13, 2019
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пожалуйста, внеси изменения. В основном улучшение изложения. Спасибо!

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 14, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team May 14, 2019 04:29
@iliakan iliakan added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 14, 2019
@ca11ado
Copy link
Contributor Author

ca11ado commented May 14, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 14, 2019
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По виду предыдущие правки не учтены, посмотри, пожалуйста.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 15, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ca11ado
Copy link
Contributor Author

ca11ado commented May 15, 2019

/done
я извиняюсь, запушил в прошлый PR

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 15, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team May 15, 2019 08:35
@iliakan
Copy link
Member

iliakan commented May 20, 2019

🚀

@javascript-translate-bot javascript-translate-bot merged commit 9f257bc into javascript-tutorial:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 One more review needed review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants