Class basic syntax by egorzot · Pull Request #192 · javascript-tutorial/ru.javascript.info

egorzot · 2019-05-19T02:50:36Z

No description provided.

dandgerson

Благодарю за перевод. Проделана большая работа!

Добавил несколько предложений по улучшению.
Взгляните пожалуйста =)

@iliakan @lex111 @egorzot буду рад фидбеку - "всё ли по делу?"

1-js/09-classes/01-class/article.md

javascript-translate-bot · 2019-05-19T07:44:57Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

1-js/09-classes/01-class/1-rewrite-to-class/task.md

egorzot · 2019-05-20T08:45:50Z

@lex111 можете глянуть вот эти места
раз два три

egorzot · 2019-05-21T06:04:30Z

/done

egorzot · 2019-05-21T06:05:22Z

@iliakan @lex111 посмотрите пожалуйста вот этот коммент

egorzot · 2019-05-21T12:45:34Z

/done

1-js/09-classes/01-class/article.md

javascript-translate-bot · 2019-05-21T14:42:06Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>

iliakan

Такое впечатление, что перевод начал делаться давно, по старой англ версии, там было обновление в Summary, посмотрите пожалуйста его.

pull c upstream please, может быть что-то еще.

Спасибо!

1-js/09-classes/01-class/article.md

javascript-translate-bot · 2019-06-01T18:00:28Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

egorzot · 2019-06-04T10:28:17Z

Такое впечатление, что перевод начал делаться давно, по старой англ версии, там было обновление в Summary, посмотрите пожалуйста его.

@iliakan вы правы - ревью проходят медленнее, чем вносятся правки в основной реп. ветку обновлю.

iliakan · 2019-06-04T10:29:44Z

Спасибо, в следующий раз сделаю ревью оперативно.

xcurveballx · 2019-06-12T11:06:00Z

@egorzot как у вас дела? Есть ли возможность внести предложенные правки и решить конфликт?

egorzot · 2019-06-12T12:45:48Z

Да, конечно. Думаю завтра уже будет PR

…

On Jun 12, 2019, at 21:06, Frontender ***@***.***> wrote: @egorzot как у вас дела? Есть ли возможность внести предложенные правки и решить конфликт? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

egorzot · 2019-06-13T08:43:28Z

pull c upstream please, может быть что-то еще.

Не сделал пулл с апстрима, там конфликты не разрезолвились. Вместо этого прошелся по всем изменениям в коммитах и взял актуальные изменения, так что перевод свежий.
Правки от Ильи Кантора все зарезолвил.

egorzot · 2019-06-14T01:42:00Z

/done

1-js/09-classes/01-class/article.md

javascript-translate-bot · 2019-06-14T20:27:06Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

…asic_syntax # Conflicts: # 1-js/09-classes/01-class/article.md

egorzot · 2019-06-16T12:50:09Z

/done

iliakan · 2019-06-16T13:42:12Z

🚀

Class basic syntax

3b84c33

javascript-translate-bot added the review needed Review needed, please approve or request changes label May 19, 2019

javascript-translate-bot requested a review from a team May 19, 2019 02:50

Merge branch 'master' into class_basic_syntax

67c9d84

dandgerson mentioned this pull request May 19, 2019

Class basic syntax #191

Closed

dandgerson requested changes May 19, 2019

View reviewed changes

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 19, 2019

dandgerson reviewed May 19, 2019

View reviewed changes

1-js/09-classes/01-class/1-rewrite-to-class/task.md Show resolved Hide resolved

dandgerson reviewed May 19, 2019

View reviewed changes

1-js/09-classes/01-class/1-rewrite-to-class/task.md Outdated Show resolved Hide resolved

egorzot added 3 commits May 20, 2019 14:20

правки

a40a3bd

правки

d649caf

правки

5639db0

iliakan mentioned this pull request May 20, 2019

Russian Translation Progress #60

Closed

правки

b51e88b

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels May 21, 2019

javascript-translate-bot requested a review from a team May 21, 2019 06:04

правки

6b07c79

lex111 requested changes May 21, 2019

View reviewed changes

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels May 21, 2019

egorzot and others added 2 commits May 22, 2019 00:44

Update 1-js/09-classes/01-class/article.md

fd8452d

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>

Update 1-js/09-classes/01-class/article.md

b894ccb

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>

iliakan requested changes Jun 1, 2019

View reviewed changes

javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jun 1, 2019

iliakan added needs +1 One more review needed and removed ready to merge labels Jun 1, 2019

egorzot added 2 commits June 13, 2019 11:43

правки

e78fcc6

Merge branch 'master' into class_basic_syntax

294f6f0

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jun 14, 2019

javascript-translate-bot requested a review from a team June 14, 2019 01:42

iliakan requested changes Jun 14, 2019

View reviewed changes

1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved

javascript-translate-bot removed the review needed Review needed, please approve or request changes label Jun 14, 2019

javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jun 14, 2019

egorzot added 3 commits June 16, 2019 22:47

/done

5a12d66

Merge remote-tracking branch 'origin/class_basic_syntax' into class_b…

acdbe6f

…asic_syntax # Conflicts: # 1-js/09-classes/01-class/article.md

/done

c3941bb

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jun 16, 2019

javascript-translate-bot requested a review from a team June 16, 2019 12:50

javascript-translate-bot merged commit 6806696 into javascript-tutorial:master Jun 16, 2019

egorzot deleted the class_basic_syntax branch June 19, 2019 06:38

Conversation

egorzot commented May 19, 2019

Uh oh!

dandgerson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 19, 2019

Uh oh!

Uh oh!

Uh oh!

egorzot commented May 20, 2019

Uh oh!

egorzot commented May 21, 2019

Uh oh!

egorzot commented May 21, 2019

Uh oh!

egorzot commented May 21, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented May 21, 2019

Uh oh!

iliakan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 1, 2019

Uh oh!

egorzot commented Jun 4, 2019

Uh oh!

iliakan commented Jun 4, 2019

Uh oh!

xcurveballx commented Jun 12, 2019

Uh oh!

egorzot commented Jun 12, 2019 via email

Uh oh!

egorzot commented Jun 13, 2019

Uh oh!

egorzot commented Jun 14, 2019

Uh oh!

Uh oh!

javascript-translate-bot commented Jun 14, 2019

Uh oh!

egorzot commented Jun 16, 2019

Uh oh!

iliakan commented Jun 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants