Skip to content

Sync with upstream @ ec21af8a#35

Closed
javascript-translate-bot wants to merge 1323 commits intomasterfrom
sync-ec21af8a
Closed

Sync with upstream @ ec21af8a#35
javascript-translate-bot wants to merge 1323 commits intomasterfrom
sync-ec21af8a

Conversation

@javascript-translate-bot

This PR was automatically generated to merge changes from en.javascript.info at ec21af8

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

Click to open a list of 206 files

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

Please ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).

This PR will be closed and replaced with a new one in a few days.

hrodward and others added 26 commits October 31, 2019 07:29
Grammar suggestions, one rephrase
Grammar suggestions
Rephrase
fix mini typo
code non-compatible with clarification drawing
code non-compatible with clarification drawing
arrow function instead of function
"helper function" term reminds "utility libraries" but "wrapper" term refers "function decorators" and in this context wrapper can be more self-descriptive and meaningful.
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 8 committers have signed the CLA.

✅ iliakan
✅ Violet-Bora-Lee
❌ lumosmind
❌ TomSssM
❌ richardzhanghub
❌ hrodward
❌ lex111
❌ ogaclejapan
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.