Script Editor: Fix script loading #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error:
```
app.30bb9074a7a632ce30a5.js:2 TypeError: Cannot read properties of undefined (reading 'length')
at i.overviewPage (app.30bb9074a7a632ce30a5.js:2:1827039)
…
```
Also refactor the code for better readability.
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…penhab#2415) The current icons are too crowded for mobile devices. This PR combines the renderer choice and the show labels into one icon. Before <img width="409" alt="image" src="https://github.com/openhab/openhab-webui/assets/2554958/8c294ca4-8fce-4379-9635-fd4e053fc77c"> After <img width="434" alt="image" src="https://github.com/openhab/openhab-webui/assets/2554958/d04b59ef-50bf-4783-aab1-99493a8c9cf3"> --------- Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Related to openhab/openhab-alexa#660. Signed-off-by: jsetton <jeremy.setton@gmail.com>
Fixes openhab/openhab-docs#2243. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
- Display specific title for each tab, but avoid becoming too long on smaller screens. - Don't autofocus on the search bar on mobile because it opens up the on-screen keyboard and covers up half the screen. --------- Also-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…penhab#2409) Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…openhab#2418) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.53 to 0.10.63. Signed-off-by: dependabot[bot] <support@github.com>
This PR adds dirty checking in the rule module popup. Rule module popup comes up when you're editing a rule's module, e.g. trigger, action, condition. Previously when you opened the rule module and made changes, then clicked back, you wouldn't get a warning and the changes will simply be lost. --------- Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Resolves openhab#2416. Depends on openhab/openhab-docs#2260. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…openhab#2425) The status badges are displayed based on the actual state of that status category. This causes the measurement badges, which are always shown to be either first or second line. This swaps those, so that measurement badges don't move around anymore. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Previously, when hovering over a `oh-player-control` component, a tooltip, which shouldn't be there, was shown. This was caused by the config title being set as the divs title. It is now fixed by manually setting title to an empy string. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…2428) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
It conflicts with the multi-select plugin and the same functionality is provided by the multi-select plugin Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
…entation (openhab#2430) Follow-up for openhab#2423. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This removes Cordova from Main UI. Cordova was used to build Main UI as an iOS or Android app (a webview with pre-packed assets), but the Cordova component of Main UI is currently unmaintained due to requiring lots of maintenance. Both the iOS and the Android app have an integrated webview (without pre-packed assets though), so Cordova is unlikely to be required in the future. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Regression from openhab#2267. This fixes the service-worker and switches from injecting the manifest into a pre-provided service-worker to generating the service-worker during webpack builder. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Closes openhab/openhab-core#4082. This PR adds: 1. A curated list of units to show as a drop-down list when creating a Number item with dimension. 2. The possibility to use a different default unit on item creation than the system default unit. 3. The ability to change unit and state description for items. 4. The ability to use the `unitHint` provided by channel types for "Link channel to Item" -> "Create a new Item". By default, the system default unit (for the configured measurement system) will be shown when editing or creating an item. `units.js` contains a number of frequently used units by dimension and measurement system. These will be available in a autosuggest dropdown list. It is still possible to not select from the list and use any other string as a unit. All units for the dimension in `units.js` will be in the dropdown list, but they will be sorted by measurement system. If the measurement system is set to US, imperial units will appear higher in the list. Units that have not explicitely been listed as SI or US will always appear higher. When typing a unit that is not in the curated list, a longer list will be used for autocompletion that considers allowed prefixes to base units and constructs all combinations. `units.js` also contains a field to set a different default unit on item creation than the system default unit. With openhab/openhab-core#4079, the REST API of channel types will provide a unit hint if defined in the binding channel types. If such information is available, this PR adds support for this to be the the suggested unit. If that information is unavailable, the UI will fall back to behavious described above. --------- Also-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
…b#2438) Regression from openhab#2294. When the developer dock was opened the first time, the navbar was not center aligned due to a styling issue because of the lazy loading. This works-around this by setting (sub)title after component creation. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…penhab#2440) Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…nhab#2441) Refs openhab/openhab-core#4123. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from openhab#2374