Skip to content

schedule-builder: fix EOL branches without a next release - #4510

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
xmudrii:fix-eol
Aug 31, 2026
Merged

schedule-builder: fix EOL branches without a next release#4510
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
xmudrii:fix-eol

Conversation

@xmudrii

@xmudrii xmudrii commented Aug 31, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

schedule-builder skipped release branches with no next patch release before ever checking their end of life date, so branches whose final patch already shipped (e.g. 1.33) were never moved to eol.yaml. The end of life check now runs first, falling back to the newest previousPatches entry and the scheduled endOfLifeDate.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

Fixed `schedule-builder` not moving a release branch to `eol.yaml` when the branch no longer has a `next` patch release set

/assign @saschagrunert @cpanato @puerco
cc @kubernetes/release-engineering

@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2026
@kubernetes-prow kubernetes-prow Bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 31, 2026
@kubernetes-prow kubernetes-prow Bot added needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 31, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from jrsapi and salaxander August 31, 2026 13:06
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2026
Comment thread cmd/schedule-builder/cmd/markdown.go Outdated
Comment thread cmd/schedule-builder/cmd/markdown.go
@xmudrii

xmudrii commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

@saschagrunert Fixed, PTAL.

@saschagrunert

Copy link
Copy Markdown
Member

@saschagrunert Fixed, PTAL.

Lint CI is not green unfortunately.

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit 0ef1097 into kubernetes:master Aug 31, 2026
11 checks passed
@xmudrii
xmudrii deleted the fix-eol branch August 31, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants