M-L01: return correct errors during state advancement validation

[philanton]

Description

The Ledger.Equal() method in pkg/core/types.go formats error messages with l1 labeled as "expected" and l2 labeled as "proposed":

func (l1 Ledger) Equal(l2 Ledger) error {
    if l1.TokenAddress != l2.TokenAddress {
        return fmt.Errorf("token address mismatch: expected=%s, proposed=%s", l1.TokenAddress, l2.TokenAddress)
    }
    // ... same pattern for other fields
}

However, both call sites in pkg/core/state_advancer.go pass the proposed state as the receiver and the expected state as the argument:

proposedState.HomeLedger.Equal(expectedState.HomeLedger)   

proposedState.EscrowLedger.Equal(*expectedState.EscrowLedger)

This causes error messages to show the expected and proposed values swapped, making debugging harder.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d33c778-d598-4f07-aeb5-bce322d88b4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/clearnode-l-01

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}