Skip to content

fix: run forge fmt#681

Merged
philanton merged 1 commit into
mainfrom
fix/forge-fmt
Apr 13, 2026
Merged

fix: run forge fmt#681
philanton merged 1 commit into
mainfrom
fix/forge-fmt

Conversation

@philanton
Copy link
Copy Markdown
Contributor

@philanton philanton commented Apr 13, 2026

Summary by CodeRabbit

  • Style
    • Minor code formatting improvements to contract files with no functional changes.

@philanton philanton merged commit f75f5ec into main Apr 13, 2026
4 of 7 checks passed
@philanton philanton deleted the fix/forge-fmt branch April 13, 2026 10:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9bcfe1c4-e4db-4d2d-aeb9-16c3df8535b7

📥 Commits

Reviewing files that changed from the base of the PR and between 909ab33 and fbfd7d6.

📒 Files selected for processing (2)
  • contracts/src/ChannelHub.sol
  • contracts/test/ChannelHub_units/ChannelHub_challenge.t.sol

📝 Walkthrough

Walkthrough

This pull request contains formatting and structural reorganization of code in the ChannelHub contract and its test suite. A require statement in challengeChannel() is reformatted from multi-line to single-line, and an import statement in the test file is reorganized across multiple lines. All functionality and logic remain unchanged.

Changes

Cohort / File(s) Summary
ChannelHub Contract Changes
contracts/src/ChannelHub.sol
Reformatted require guard in challengeChannel() from multi-line to single-line format for StateIntent.INITIATE_ESCROW_DEPOSIT validation; logic and error handling unchanged.
Test Suite Imports
contracts/test/ChannelHub_units/ChannelHub_challenge.t.sol
Reorganized named import block for Types.sol from single-line to multi-line format for improved readability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ihsraham
  • dimast-x

Poem

🐰 A hop, a skip, through cleaner lines,
Where require statements now align,
Imports flow in vertical grace,
No logic changed, just formatting space,
A tidy burrow, the code divine! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/forge-fmt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

nksazonov added a commit that referenced this pull request Apr 16, 2026
H-H01: fix(contracts): disallow challenge with CLOSE or FIN_MIG intents (#631)

H-M01: fix(contracts/ChannelHub): remove transferred amount check (#636)

fix(contracts/ChannelHub): allow unblocking escrow ops after migration (#637)

M-C01: feat(contracts): add token check between states (#639)

H-L03: fix(contracts/ChannelHub): skip disputed escrow during purge (#640)

M-H04: feat(contracts/ChannelHub): purge during escrow challenge finalization, count both skip and purge (#641)

M-M02: fix(contracts): require zero allocs on close (#643)

M-C02: fix(rpc/core): apply finalize escrow deposit correctly (#644)

H-L02: fix(contracts/ChannelHub): revert on withdrawFromVault failure (#651)

M-H03: fix(clearnode): log correct fields on failure (#647)

M-C03: fix(pkg/core): disallow negative amount transitions (#645)

H-L01: fix(contracts/ChannelHub): add CH address to prevent val addition replay (#650)

M-H06(clearnode): restrict max channel challenge duration (#654)

M-M03(clearnode): revert EscrowLock on insufficient home user balance (#655)

M-M04(clearnode): support default signer even if it is not approved (#656)

M-M05(clearnode): require correct intent on FinalizeEscrowWithdrawal (#657)

M-M09: reject asset decimals exceeding its token's decimals (#659)

M-L01: return correct errors during state advancement validation (#660)

M-L03: limit number of related ids per session key state (#662)

M-I02: normalize input hex addresses (#663)

M-H01: feat(contracts/ChannelHub): restrict to one node (#649)

M-H07: fix(contracts/ChannelHub): emit stored, not arbitrary candidate state (#664)

M-I01: feat(contracts/ChannelHub): remove updateLastState flag (#665)

H-L06: fix(contracts/ChannelHub): remove payable from methods, clarify in create (#666)

H-L09: feat(contracts/ChannelEngine): add non-home migration version check (#669)

YNU-839: fix blockchain listener lifecycle (#658)

M-H09: use channel signer for all channel state node sigs (#667)

H-L07: fix(contracts/ChannelHub): restrict createChannel to non-existing channels (#668)

H-I02: docs(contracts): add a note that rebasing tokens are not supported (#670)

H-I03: fix(contracts/ChannelHub): use CIE pattern in depositToHub (#671)

M-H11: revert empty signatures on quorum verification (#672)

M-H11: reject issuance of receiver state during escrow ops (#674)

H-I01: docs(contracts): note that fee-on-transfer tokens are not supported (#675)

M-L04: docs: mention liquidity monitoring (#677)

fix(contracts/ChannelHub): fix initialize escrow deposit dos (#679)

M-H08: enforce strict transition ordering after MutualLock and EscrowLock (#680)

fix: run forge fmt (#681)

M-L05: docs(contracts): document native token deposits (#685)

fix(clearnode): resolve a set of audit findings (#686)

M-H13: feat(contract): add validateChallengeSignature, revert in SK validator (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant