Skip to content

chore(CategoryTheory): implicit_reducible for compositions of natural transformations - #42528

Open
joelriou wants to merge 3 commits into
leanprover-community:masterfrom
joelriou:nattrans-implicit-reducible
Open

chore(CategoryTheory): implicit_reducible for compositions of natural transformations#42528
joelriou wants to merge 3 commits into
leanprover-community:masterfrom
joelriou:nattrans-implicit-reducible

Conversation

@joelriou

@joelriou joelriou commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary 08f1f38de4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 08f1f38).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 08f1f38de4
Reference commit daa38bd533

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou

joelriou commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Aug 7, 2026

Copy link
Copy Markdown

Benchmark results for 6a4614d against daa38bd are in. No significant results found. @joelriou

  • 🟥 build//instructions: +4.7G (+0.00%)

No significant changes detected.

@joelriou joelriou added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 7, 2026

@robin-carlier robin-carlier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 7, 2026
@JovanGerb

JovanGerb commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

I have a PR (#40925) that no_exposes hcomp. What should we do?

@robin-carlier

robin-carlier commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

I would say hcomp as no_expose makes sense. The important one at implicit_reducible here is definitely vcomp (so that NatTrans.comp_app can be an @[defeq])

@joelriou

joelriou commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

I have reverted the change about vcomp. This PR now only makes hcomp (i.e. the composition in the category of functors) implicit_reducible.

@robin-carlier

Copy link
Copy Markdown
Contributor

@joelriou It’s the other way around: vcomp is the composition in the category of functors.

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 8, 2026
@joelriou

joelriou commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

@joelriou It’s the other way around: vcomp is the composition in the category of functors.

Thanks for spotting this! Fixed.

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 8, 2026
@JovanGerb

Copy link
Copy Markdown
Contributor

Thanks! It now looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants