Skip to content

chore(CategoryTheory): composition implicit reducible in Type - #42529

Open
joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:fun-comp-implicit-reducible
Open

chore(CategoryTheory): composition implicit reducible in Type#42529
joelriou wants to merge 2 commits into
leanprover-community:masterfrom
joelriou:fun-comp-implicit-reducible

Conversation

@joelriou

@joelriou joelriou commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This is meant to be used in combination with #42528 in order to have better "defeq" for categories of functors to types.


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

PR summary a984642caa

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a984642).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit a984642caa
Reference commit daa38bd533

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou

joelriou commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Aug 7, 2026

Copy link
Copy Markdown

Benchmark results for a08b3dc against daa38bd are in. No significant results found. @joelriou

  • 🟥 build//instructions: +18.4G (+0.01%)

No significant changes detected.

@joelriou joelriou added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 7, 2026

@robin-carlier robin-carlier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this tag, is the +dsimpLHs option on simps still needed?

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 7, 2026
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 7, 2026
@robin-carlier

Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants