Allow logins during lockdown#5202
Merged
benjaoming merged 1 commit intolearningequality:masterfrom Jul 26, 2016
Merged
Conversation
Students were not able to login when lockdown was activated because /securesync/api/user/login was not whitelisted. Tested and working after this change.
Contributor
|
Agreeing, that seems like the likely cause, thanks for fixing and confirming functionality restored! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lockdown feature was still not working as expected. Students were still not able to login when lockdown activated. @benjaoming made a fix that got rid of page redirect error that was previously present when lockdown was activated
Issues addressed
#5150
Students were not able to login when lockdown was activated because /securesync/api/user/login was not whitelisted. Tested and working after this change.