Add CAAIdentities and Website to /directory "meta".#3588
Merged
Conversation
This commit updates the WFE and WFE2 to have configuration support for setting a value for the `/directory` object's "meta" field's optional "caaIdentities" and "website" fields. The config-next wfe/wfe2 configuration are updated with values for these fields. Unit tests are updated to check that they are sent when expected and not otherwise. Bonus content: The `test.AssertUnmarshaledEquals` function had a bug where it would consider two inputs equal when the # of keys differed. This commit also fixes that bug.
jsha
approved these changes
Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the WFE and WFE2 to have configuration support for
setting a value for the
/directoryobject's "meta" field'soptional "caaIdentities" and "website" fields. The config-next wfe/wfe2
configuration are updated with values for these fields. Unit tests are
updated to check that they are sent when expected and not otherwise.
Bonus content: The
test.AssertUnmarshaledEqualsfunction had a bugwhere it would consider two inputs equal when the # of keys differed.
This commit also fixes that bug.
There's a little bit of duplication between the WFE and WFE2 but this
isn't a great fit for the
webpackage. In both cases we need to be readingfields from the config that are package specific. For the WFE we need to use
"terms-of-service" for one meta key, in the WFE2 "termsOfService". Putting
this work into
webdidn't really make it much cleaner so I left the duplication.Resolves #2811