Excise code relating to pre-SCT embedding issuance flow#3769
Conversation
|
I deleted the |
cpu
left a comment
There was a problem hiding this comment.
This is a really nice diff 😍
Beyond the deployability concern you flagged RE: the EmbedSCTs feature I think removing RPCs will need to be done in a follow-up after all the client code that called the to-be-removed RPCs is removed, no?
| @@ -130,11 +129,8 @@ var ( | |||
| // |TestIssueCertificate| quite a bit, and since it isn't clear that that | |||
There was a problem hiding this comment.
Not directly caused by this PR, but I don't understand this comment. Can it be removed/rephrased?
There was a problem hiding this comment.
I think it is still correct, but tbh I'm not 100% sure I understand what it's saying, so ¯\_(ツ)_/¯.
None of the RPCs that are removed are currently used in any hot code paths in boulder so it should be safe to rip them all out in one fell swoop. |
This ended up being a bit... bigger than I expected.
Things removed:
Fixes #3755.